Review main Merged

41667[BUGFIX] Implement EXT: usage in addModule

Wouter Wolters CR +2 V +2 Easy +14 −3 updated 07/20/15, 12:20

Commit message

Make it possible to use EXT: for resolving paths in addModule

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1

Issues 1

Files 2

Review log 11

  1. Wouter Wolters uploaded patch set 1 07/18/15, 12:32

  2. Michael Oehlhof commented on patch set 1 V +1 07/18/15, 14:23

    Little optimization hints for the code.

    ModuleLoader.php:275

    Maybe use StringUtility:beginsWith here.

    ExtensionManagementUtility.php:918

    Maybe use StringUtility:beginsWith here.
  3. Wouter Wolters uploaded patch set 2 07/18/15, 14:34

  4. Wouter Wolters uploaded patch set 3 07/18/15, 14:36

  5. Benni Mack uploaded patch set 4 07/18/15, 16:51

  6. Benni Mack voted on patch set 4 CR +1 V +1 07/18/15, 17:40

  7. Georg Ringer voted on patch set 4 CR +1 V +1 07/19/15, 07:03

  8. Benni Mack voted on patch set 4 CR +2 V +2 07/19/15, 07:42

  9. Benni Mack merged patch set 4 07/19/15, 07:42

  10. Wouter Wolters commented on patch set 5 07/20/15, 12:09

    ModuleLoader.php:273

    this doesn't work anymore, fixed in the 6.2 patch. Followup will follow
  11. Wouter Wolters commented on patch set 5 07/20/15, 12:20

    ModuleLoader.php:273 Reply

    false alarm. the code was really strange in the backport of 6.2 all good here and now the complete backport is ready for 6.2