41676[FEATURE] Include a pageTSconfig file like TS static templates
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Stefan Neufeind +1
- Frank Nägler +1
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Frank Nägler +1
- Susi Moog +1
Issues 2
Files 6
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+27 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php10+17 −0
- typo3/sysext/core/Configuration/TCA/pages.php1+13 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-68315-IncludeAPageTSconfigFileInPagePropertiesLikeTSStaticTemplates.rst2new+27 −0
- typo3/sysext/core/ext_tables.sql+1 −0
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+3 −0
Review log 36
Show 11 earlier messages
-
Jigal van Hemert uploaded patch set 1 07/18/15, 14:24
-
Benjamin Kott uploaded patch set 2 07/18/15, 17:37
-
filigivuji filigivuji commented on patch set 2 07/18/15, 17:48
-
Jigal van Hemert uploaded patch set 3 07/18/15, 17:56
-
Jigal van Hemert commented on patch set 3 07/19/15, 08:22
> (1 comment) In PHP function names are case insensitive. Our Coding Guidelines state that function names are lower camelcase and that this applies to acronyms too. We usually leave old function names as they are. http://docs.typo3.org/typo3cms/CodingGuidelinesReference/PhpFileFormatting/PhpSyntaxFormatting/Index.html -
Benjamin Kott uploaded patch set 4 07/19/15, 09:21
-
Anja Leichsenring uploaded patch set 5 07/19/15, 09:46
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 07/19/15, 09:48
-
Benni Mack commented on patch set 5 07/19/15, 15:37
pages.php:805I'm for naming this thing "tsconfig_includes", hope that's ok with you! -
Benjamin Kott uploaded patch set 6 07/20/15, 09:14
-
Benjamin Kott commented on patch set 6 CR -1 V -1 07/20/15, 09:17
Renamed fields. Create a file with `TCEFORM.pages.TSconfig.disabled = 1`. Will have no effect on the form in the backend.
-
Benjamin Kott uploaded patch set 7 07/20/15, 21:29
-
Benjamin Kott voted on patch set 7 CR +1 V +1 07/20/15, 21:33
-
Wouter Wolters commented on patch set 7 07/20/15, 21:42
BackendUtility.php:1242use StringUtility::beginsWith hereExtensionManagementUtility.php:1443$extKey -
Benjamin Kott uploaded patch set 8 07/20/15, 21:56
-
Benjamin Kott voted on patch set 8 CR +1 V +1 07/20/15, 21:56
-
Stefan Neufeind commented on patch set 8 CR -1 07/21/15, 01:36
ExtensionManagementUtility.php:1436imho we should strongly suggest to use it in "Configuration/TCA/Overrides/pages.php" instead (no ext_tables.php for new things, if possible). The TCA for pages already lives under the Configuration-tree, so should we override-able and cacheable through the clean way.Feature-68315-IncludeAPageTSconfigFileInPagePropertiesLikeTSStaticTemplates.rst:27Name it "PageTs" instead of "PageTS" imho. We have that upper-/lowercase like this in the method-names already and also the recommended folder for CSS is "Css" (see official docs at: http://docs.typo3.org/typo3cms/CoreApiReference/ExtensionArchitecture/FilesAndLocations/Index.html) -
Marc Bastian Heinrichs commented on patch set 8 07/21/15, 07:26
In general I would like to avoid more configuration in database, when e.g. thinking of deployment. And you already could use page tree based conditions in TSconfig. A real improvement would be to have an auto mechnism to add file based TSconfig based on the naming schema to sub trees.ExtensionManagementUtility.php:1443compared to addPageTSConfig this method acts different, but one could read the name that it acts like ExtensionManagementUtility::addPageTSConfig('<INCLUDE_TYPOSCRIPT: source="FILE: So I would suggest a name to use something with "register". -
Jigal van Hemert commented on patch set 8 07/21/15, 09:47
Can't really vote as owner, but thanks Benji for adding the missing line; somehow it was removed when I copied things around before committing.ExtensionManagementUtility.php:1436ReplyFeel free to add it to the header and push a new patch set.ExtensionManagementUtility.php:1443ReplyIt acts the same as ExtensionManagementUtility::addStaticFile(). Hence the name. -
Benjamin Kott commented on patch set 8 CR 0 V 0 07/21/15, 20:02
I agree that a general autoloading would be cool, but takes more time, planning and a concept for multisites. We currently need a way to make it more easy for users and "Distributions" to add PageTS for a single tree without writing the include path into the pagets field or writing a lot of stuff in there and do better in educating that also PageTS should not be stored in the database. Adding a reference is for me the minimal approach, thats simply better than nothing. Will push a patch.ExtensionManagementUtility.php:1436ReplyDoneExtensionManagementUtility.php:1443ReplyI agree that addPageTSConfig could be missleading even the typoscript counterpart has a similar naming. Will go for registerPageTSConfigFile instead.Feature-68315-IncludeAPageTSconfigFileInPagePropertiesLikeTSStaticTemplates.rst:27Replyrtehtmlarea is currently using also PageTS so i will keep it for now. -
Benjamin Kott uploaded patch set 9 07/21/15, 20:03
-
Benjamin Kott voted on patch set 9 CR +1 V +1 07/21/15, 20:05
-
Daniel Goerz voted on patch set 9 CR +1 V +1 07/21/15, 21:35
-
Frank Nägler commented on patch set 9 07/22/15, 07:26
BackendUtility.php:1256why we need the @ operator here? -
Frank Nägler commented on patch set 9 CR -1 07/22/15, 07:31
on it -
Frank Nägler uploaded patch set 10 07/22/15, 08:05
-
Anja Leichsenring voted on patch set 10 CR +1 V +1 07/22/15, 08:07
-
Anja Leichsenring voted on patch set 10 V 0 07/22/15, 08:14
-
Stefan Neufeind voted on patch set 10 CR +1 07/22/15, 08:17
-
Frank Nägler commented on patch set 10 CR +1 V -1 07/22/15, 08:20
sorry, need to give -1 because I can't get it running. I have created a TSConfig file, register it and add to page. I can't see the TSConfig from the file in the Info module nor is the TSConfig applied to the page. Maybe it is my mistake, but currently I can't verify it. -
Frank Nägler commented on patch set 10 V +1 07/22/15, 08:25
sorry, I found my mistake. it works... -
Susi Moog voted on patch set 10 CR +1 V +1 07/22/15, 08:35
-
Anja Leichsenring voted on patch set 10 CR +2 V +2 07/22/15, 08:42
-
Anja Leichsenring merged patch set 10 07/22/15, 08:42
-
Markus Klein commented on patch set 11 07/22/15, 08:54
ExtensionManagementUtility.php:1436I actually disagree on mentioning ext_tables here at all, since we heavily try to get that out of people's minds.ExtensionManagementUtility.php:1444omitting the else part here is not a good idea. tell the dev why his file is not added. -
Markus Klein commented on patch set 11 11/17/15, 19:41
Post -1 you missed implementing this in \TYPO3\CMS\Core\TypoScript\TemplateService::mergeConstantsFromPageTSconfig https://forge.typo3.org/issues/71640
ExtensionManagementUtility.php:1433