Review main Merged

41702[TASK] EXT:impexp Uniform extension directory structure

Michael Oehlhof CR +2 V +2 Easy +1 −2 updated 07/20/15, 14:28

Commit message

Moved the code from the app directory to the Modules/ImportExport directory.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Frank Nägler +1

Issues 1

Files 3

Review log 10

  1. Michael Oehlhof uploaded patch set 1 07/19/15, 10:23

  2. Susi Moog voted on patch set 1 CR +1 V +1 07/20/15, 11:36

  3. Frederic Gaus voted on patch set 1 CR +1 V +1 07/20/15, 13:21

  4. Wouter Wolters commented on patch set 1 07/20/15, 14:00

    conf.php:2

    this backpath is not correct anymore, not sure if this is still used.
  5. Frank Nägler commented on patch set 1 CR -1 07/20/15, 14:10

    on it
  6. Frank Nägler uploaded patch set 2 07/20/15, 14:23

  7. Frank Nägler commented on patch set 2 CR +1 V +1 07/20/15, 14:24

    I removed the BACK_PATH, think also it is not needed anymore, and I can't find an issue without it.
  8. Wouter Wolters commented on patch set 2 V +1 CR +1 07/20/15, 14:24

    Couldn't find one myself.
  9. Susi Moog voted on patch set 2 CR +2 V +2 07/20/15, 14:27

  10. Susi Moog merged patch set 2 07/20/15, 14:28