Review main Merged

41710[TASK] EXT:setup Uniform extension directory structure

Michael Oehlhof CR +2 V +2 Easy +2 −2 updated 07/20/15, 13:19

Commit message

Moved the code from the mod directory to the Modules/Setup directory.

Review

  • Code review CR +2
    • Stefan Froemken +2
    • Susi Moog +1
  • Verified V +2
    • Stefan Froemken +2
    • Susi Moog +1

Issues 1

Files 4

Review log 6

  1. Michael Oehlhof uploaded patch set 1 07/19/15, 16:45

  2. Susi Moog voted on patch set 1 CR +1 V +1 07/20/15, 11:43

  3. Stefan Froemken commented on patch set 1 CR -1 07/20/15, 13:07

    You have removed the clear.gif icon, but it was still referenced in SetupModuleController.php at line 464.
  4. Susi Moog commented on patch set 1 07/20/15, 13:10

    At first I thought so, too, but the referenced clear.gif gets loaded relative to the TYPO3 main dir (typo3/clear.gif), therefore the one in the extension can be removed.
  5. Stefan Froemken commented on patch set 1 CR +2 V +2 07/20/15, 13:19

    You're right
  6. Stefan Froemken merged patch set 1 07/20/15, 13:19