Review main Merged

41711[BUGFIX] Use correct class names for task manager registrations and links

Daniel Goerz CR +2 V +2 Easy +5 −5 updated 07/20/15, 17:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 12

  1. Daniel Goerz uploaded patch set 1 07/19/15, 19:39

  2. Daniel Goerz uploaded patch set 2 07/19/15, 19:47

  3. Hans Mayer voted on patch set 2 CR +1 V +1 07/20/15, 07:10

  4. Markus Klein commented on patch set 2 07/20/15, 07:20

    Does that one influence some stored actions as well?

    ext_tables.php:6

    \ should be escaped to \\
  5. Daniel Goerz uploaded patch set 3 07/20/15, 07:31

  6. Daniel Goerz commented on patch set 3 07/20/15, 07:33

    > (1 comment) > > Does that one influence some stored actions as well? What do you mean by "stored actions"? Do you mean already created sys_action records? Then the only influence is, that now they can be executed again :)
  7. Markus Klein commented on patch set 3 07/20/15, 08:16

    Just a few more comments then.
    Please start with uppercase U

    ImportExportTask.php:131

    the \ thingy applies here too of course

    ActionTask.php:174

    and here

    ActionTask.php:401

    and here
  8. Daniel Goerz uploaded patch set 4 07/20/15, 08:23

  9. Wouter Wolters voted on patch set 4 V +1 CR +1 07/20/15, 17:40

  10. Christian Kuhn commented on patch set 4 07/20/15, 17:45

    on it.
  11. Christian Kuhn commented on patch set 4 CR +2 V +2 07/20/15, 17:48

    task center list is back :)
  12. Christian Kuhn merged patch set 4 07/20/15, 17:49