41714[BUGFIX] Allow editing of shortcuts for non-admin users
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Frederic Gaus +1
- Wouter Wolters +1
-
Verified V +2
- Susi Moog +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 6
-
Markus Klein uploaded patch set 1 07/20/15, 07:58
-
Frederic Gaus voted on patch set 1 CR +1 07/20/15, 08:07
-
Wouter Wolters voted on patch set 1 V +1 CR +1 07/20/15, 20:53
-
Stefan Neufeind commented on patch set 1 07/21/15, 01:20
Maybe I don't get it, by reading the description on forge. Is this some kind of "followup"? What didn't work before the patch: The assignment of groups (from the select of a bookmark)? -
Susi Moog commented on patch set 1 CR +2 V +2 07/21/15, 07:07
The behavior is easier to see in a 6.2 as in 7 you can't edit a bookmark and not assign a group. Problem is: as long as the bookmark has no group the user could not edit the bookmark - not even his own if he wasn't admin. Editing worked only after adding a group. In 7 I was not able to reproduce the wrong behavior as groups are always assigned, but I tested (nothing breaks) and the code does make a lot more sense this way. -
Susi Moog merged patch set 1 07/21/15, 07:07