Review main Merged

41715[TASK] Cleanup AjaxDataHandler

Frank Nägler CR +2 V +2 Normal +48 −26 updated 07/20/15, 10:33

Commit message

Decouple ajax call and reactions

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 6

  1. Frank Nägler uploaded patch set 1 07/20/15, 08:16

  2. Markus Klein commented on patch set 1 CR -1 07/20/15, 10:08

    will followup

    AjaxDataHandler.js:103

    call this toggleRow

    AjaxDataHandler.js:115

    use toggleClass

    AjaxDataHandler.js:130

    remove this one
  3. Markus Klein uploaded patch set 2 07/20/15, 10:21

  4. Markus Klein voted on patch set 2 CR +1 V +1 07/20/15, 10:21

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 07/20/15, 10:33

  6. Wouter Wolters merged patch set 2 07/20/15, 10:33