Review main Merged

41716[TASK] About modules: add two-column layout

Josef Glatz CR +2 V +2 Normal +58 −64 updated 01/09/19, 20:56

Commit message

Remove max width of the content. Add a fluid two-column
layout and add more vertical space between the submodules.
Get rid of the unneeded css file.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frederic Gaus +1
  • Verified V +2
    • Markus Klein +2
    • Frederic Gaus +1

Issues 1

Files 4

Review log 14

  1. Mathias Schreiber updated the commit message in patch set 2 01/09/19, 20:56

  2. Markus Klein commented on patch set 1 01/09/19, 20:56

    Index.html:18

    If we only need that "before" the first and "after" the last, we can simply put that outside of the for loop.

    Index.html:19

    fluid

    Index.html:24

    move this line before the if as it is done in both parts. the then part can be dropped then
  3. Josef Glatz uploaded patch set 1 01/09/19, 20:56

  4. Josef Glatz uploaded patch set 3 01/09/19, 20:56

  5. Markus Klein commented on patch set 4 2 comments 01/09/19, 20:56

  6. Markus Klein commented on patch set 4 01/09/19, 20:56

    I'll push an update
  7. Josef Glatz uploaded patch set 4 01/09/19, 20:56

  8. Josef Glatz uploaded patch set 5 01/09/19, 20:56

  9. Markus Klein voted on patch set 7 CR +1 V +1 01/09/19, 20:56

  10. Markus Klein uploaded patch set 7 01/09/19, 20:56

  11. Markus Klein voted on patch set 7 CR +2 V +2 01/09/19, 20:56

  12. Frederic Gaus voted on patch set 7 CR +1 V +1 01/09/19, 20:56

  13. Markus Klein merged patch set 7 01/09/19, 20:56

  14. Josef Glatz uploaded patch set 6 01/09/19, 20:56