Review main Merged

4181[BUGFIX] Content rendering: Definition lists in RTE are wrapped in p

Stanislas Rolland CR +2 V +2 Easy +20 −8 updated 06/03/13, 20:49

Commit message

Definition lists entered in the RTE are wrapped in paragraph tags when
rendered in the frontend. This is not valid HTML.

Solution: Add dl and dd to lib.parseFunc_RTE.externalBlocks and
process them recursively like div. Add dt to
nonTypoTagStdWrap.encapsLines.encapsTagList

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Georg Ringer +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Georg Ringer +1

Issues 1

Files 5

Review log 25

  1. Steffen Müller commented on patch set 1 02/17/12, 20:40

    Fails; I would prefer that you didn't submit this dd and dl are switched. See inline comment

    setup.txt:95

    should be dl instead of dd

    setup.txt:130

    should be dd,dt instead of dl,dt
  2. Stefan Neufeind commented on patch set 1 02/17/12, 20:40

    Looks good to me, but someone else must approve looks fine by reading PS: https://review.typo3.org/#change,4182 and https://review.typo3.org/#change,4184 are for older releases and contain the same fix - just files/filenames adjusted to that specific version. So I guess we could get this one here through first.
  3. Stanislas Rolland uploaded patch set 4 02/17/12, 20:40

  4. Stanislas Rolland uploaded patch set 5 02/17/12, 20:40

  5. Stanislas Rolland commented on patch set 5 02/17/12, 20:40

    I am unable to reproduce this behaviour with patch set 5 installed. Make sure to clear page cache and configuration cache. Make sure that lib.parseFunc_RTE is not somehow overrridden. Check also what you have in lib parseFunc.allowTags and lib.parseFunc_RTE.allowRags: these should include tags dl, dt and dd. I note that the recursion is set with lib.parseFunc rather than lib.parseFunc_RTE, and will push a new patch set to fix this.
  6. Stanislas Rolland uploaded patch set 6 02/17/12, 20:40

  7. Tolleiv Nietsch uploaded patch set 3 02/17/12, 20:40

  8. Tolleiv Nietsch commented on patch set 7 V 0 02/17/12, 20:40

    by team member; Looks good to me, approved
  9. Tolleiv Nietsch uploaded patch set 7 02/17/12, 20:40

  10. Tolleiv Nietsch commented on patch set 7 02/17/12, 20:40

    Verified; Looks good to me, but someone else must approve Patchset 7 just removed few whitespace violations. No functional change - that part worked fine for me ;)
  11. Dmitry Dulepov commented on patch set 4 02/17/12, 20:40

    Fails; I would prefer that you didn't submit this Text in the RTE: <p>p1</p> <dl><dt>aaa</dt><dd>bbb</dd></dl> <p>p2</p> Text in FE: <p class="bodytext">p1</p><dl><p class="bodytext"><dt>aaa</dt></p><dd><p class="bodytext">bbb</p></dd></dl><p class="bodytext">p2</p> Notice extra P elements inside DL.
  12. Dmitry Dulepov commented on patch set 5 02/17/12, 20:40

    Fails No change. Source in RTE: <p>p1</p> <dl><dt>aaa</dt><dd>bbb</dd></dl> <p>p2</p> <p>lala</p> Database: p1 <dl><dt>aaa</dt><dd>bbb</dd></dl> p2 lala Result: <p class="bodytext">p1</p><dl><p class="bodytext"><dt>aaa</dt></p><dd><p class="bodytext">bbb</p></dd></dl><p class="bodytext">p2 </p> <p class="bodytext">lala</p>
  13. Dmitry Dulepov commented on patch set 5 02/17/12, 20:40

    Gerrit took away all new lines :(
  14. Oliver Hader uploaded patch set 2 02/17/12, 20:40

  15. Oliver Hader commented on patch set 2 02/17/12, 20:40

    Fails; I would prefer that you didn't submit this Rebasing to master V:-1, R:-1 V:-1, R:-1 from Steffen Müller <typo3@t3node.com> V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:2 from Georg Ringer <mail@ringerge.org>
  16. Georg Ringer commented on patch set 1 02/17/12, 20:40

    Looks good to me, approved
  17. Georg Ringer commented on patch set 7 02/17/12, 20:40

    Verified; Looks good to me, but someone else must approve
  18. Mr. Jenkins commented on patch set 1 02/17/12, 20:40

  19. Mr. Jenkins commented on patch set 2 02/17/12, 20:40

  20. Mr. Jenkins commented on patch set 3 02/17/12, 20:40

  21. Mr. Jenkins commented on patch set 4 02/17/12, 20:40

  22. Mr. Jenkins commented on patch set 5 02/17/12, 20:40

  23. Mr. Jenkins commented on patch set 6 02/17/12, 20:40

  24. Mr. Jenkins commented on patch set 7 02/17/12, 20:40

  25. Tolleiv Nietsch merged patch set 7 02/17/12, 20:40