4181[BUGFIX] Content rendering: Definition lists in RTE are wrapped in p
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Georg Ringer +1
-
Verified V +2
- Tolleiv Nietsch +2
- Georg Ringer +1
Issues 1
Files 5
Review log 25
-
Steffen Müller commented on patch set 1 02/17/12, 20:40
Fails; I would prefer that you didn't submit this dd and dl are switched. See inline commentsetup.txt:95should be dl instead of ddsetup.txt:130should be dd,dt instead of dl,dt -
Stefan Neufeind commented on patch set 1 02/17/12, 20:40
Looks good to me, but someone else must approve looks fine by reading PS: https://review.typo3.org/#change,4182 and https://review.typo3.org/#change,4184 are for older releases and contain the same fix - just files/filenames adjusted to that specific version. So I guess we could get this one here through first. -
Stanislas Rolland uploaded patch set 4 02/17/12, 20:40
-
Stanislas Rolland uploaded patch set 5 02/17/12, 20:40
-
Stanislas Rolland commented on patch set 5 02/17/12, 20:40
I am unable to reproduce this behaviour with patch set 5 installed. Make sure to clear page cache and configuration cache. Make sure that lib.parseFunc_RTE is not somehow overrridden. Check also what you have in lib parseFunc.allowTags and lib.parseFunc_RTE.allowRags: these should include tags dl, dt and dd. I note that the recursion is set with lib.parseFunc rather than lib.parseFunc_RTE, and will push a new patch set to fix this. -
Stanislas Rolland uploaded patch set 6 02/17/12, 20:40
-
Tolleiv Nietsch uploaded patch set 3 02/17/12, 20:40
-
Tolleiv Nietsch commented on patch set 7 V 0 02/17/12, 20:40
by team member; Looks good to me, approved -
Tolleiv Nietsch uploaded patch set 7 02/17/12, 20:40
-
Tolleiv Nietsch commented on patch set 7 02/17/12, 20:40
Verified; Looks good to me, but someone else must approve Patchset 7 just removed few whitespace violations. No functional change - that part worked fine for me ;) -
Dmitry Dulepov commented on patch set 4 02/17/12, 20:40
Fails; I would prefer that you didn't submit this Text in the RTE: <p>p1</p> <dl><dt>aaa</dt><dd>bbb</dd></dl> <p>p2</p> Text in FE: <p class="bodytext">p1</p><dl><p class="bodytext"><dt>aaa</dt></p><dd><p class="bodytext">bbb</p></dd></dl><p class="bodytext">p2</p> Notice extra P elements inside DL. -
Dmitry Dulepov commented on patch set 5 02/17/12, 20:40
Fails No change. Source in RTE: <p>p1</p> <dl><dt>aaa</dt><dd>bbb</dd></dl> <p>p2</p> <p>lala</p> Database: p1 <dl><dt>aaa</dt><dd>bbb</dd></dl> p2 lala Result: <p class="bodytext">p1</p><dl><p class="bodytext"><dt>aaa</dt></p><dd><p class="bodytext">bbb</p></dd></dl><p class="bodytext">p2 </p> <p class="bodytext">lala</p> -
Dmitry Dulepov commented on patch set 5 02/17/12, 20:40
Gerrit took away all new lines :( -
Oliver Hader uploaded patch set 2 02/17/12, 20:40
-
Oliver Hader commented on patch set 2 02/17/12, 20:40
Fails; I would prefer that you didn't submit this Rebasing to master V:-1, R:-1 V:-1, R:-1 from Steffen Müller <typo3@t3node.com> V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:2 from Georg Ringer <mail@ringerge.org> -
Georg Ringer commented on patch set 1 02/17/12, 20:40
Looks good to me, approved -
Georg Ringer commented on patch set 7 02/17/12, 20:40
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 02/17/12, 20:40
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1585/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/17/12, 20:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2694/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/17/12, 20:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3073/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/17/12, 20:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3094/ : SUCCESS -
Mr. Jenkins commented on patch set 5 02/17/12, 20:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3095/ : SUCCESS -
Mr. Jenkins commented on patch set 6 02/17/12, 20:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3136/ : SUCCESS -
Mr. Jenkins commented on patch set 7 02/17/12, 20:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3143/ : SUCCESS -
Tolleiv Nietsch merged patch set 7 02/17/12, 20:40