Review TYPO3_4-5 Abandoned

4182[BUGFIX] Content rendering: Definition lists inserted in RTE wrapped in p

Stanislas Rolland CR 0 V 0 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Definition lists entered in the RTE are wrapped in paragraph tags when
rendered in the frontend. This is not valid HTML.

Solution: Add dl and dt to
lib.parseFunc_RTE.nonTypoTagStdWrap.encapsLines.encapsTagList
and dd to lib.parseFunc_RTE.externalBlocks

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 7

  1. Stanislas Rolland commented on patch set 1 01/21/12, 02:38

    (2 inline comments) I don't think so. But I think that recursive parsing of dd is missing. Did you test the patch?
  2. Steffen Müller commented on patch set 1 01/21/12, 02:38

    Fails; I would prefer that you didn't submit this dd and dl are switched. See inline comment

    setup.txt:95

    should be dl instead of dd

    setup.txt:95 Reply

    your suggestion does not help.

    setup.txt:126

    should be dd,dt instead of dl,dt
  3. Steffen Müller commented on patch set 1 01/21/12, 02:38

    (1 inline comment) I really tried hard to understand the documentation of these weird options. I have to admit that I failed :( But I tested your patch and it did not work. After changing the patch like explained in the commment, it did work. Please read my mail in the typo3-p.v4 mailinglist, where I added very simple example code to reproduce and demonstrate the issue and my approach.
  4. Oliver Hader uploaded patch set 2 01/21/12, 02:38

  5. Oliver Hader commented on patch set 2 01/21/12, 02:38

    Fails; I would prefer that you didn't submit this Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:-1, R:-1 as a summary of previous scores (limited to [-1;+1]) V:-1, R:-1 from Steffen Müller <typo3@t3node.com>
  6. Mr. Jenkins commented on patch set 1 01/21/12, 02:38

  7. Stanislas Rolland commented on patch set 2 01/21/12, 02:38

    Abandoned