4182[BUGFIX] Content rendering: Definition lists inserted in RTE wrapped in p
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 7
-
Stanislas Rolland commented on patch set 1 01/21/12, 02:38
(2 inline comments) I don't think so. But I think that recursive parsing of dd is missing. Did you test the patch? -
Steffen Müller commented on patch set 1 01/21/12, 02:38
Fails; I would prefer that you didn't submit this dd and dl are switched. See inline commentsetup.txt:95should be dl instead of ddsetup.txt:95Replyyour suggestion does not help.setup.txt:126should be dd,dt instead of dl,dt -
Steffen Müller commented on patch set 1 01/21/12, 02:38
(1 inline comment) I really tried hard to understand the documentation of these weird options. I have to admit that I failed :( But I tested your patch and it did not work. After changing the patch like explained in the commment, it did work. Please read my mail in the typo3-p.v4 mailinglist, where I added very simple example code to reproduce and demonstrate the issue and my approach. -
Oliver Hader uploaded patch set 2 01/21/12, 02:38
-
Oliver Hader commented on patch set 2 01/21/12, 02:38
Fails; I would prefer that you didn't submit this Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:-1, R:-1 as a summary of previous scores (limited to [-1;+1]) V:-1, R:-1 from Steffen Müller <typo3@t3node.com> -
Mr. Jenkins commented on patch set 1 01/21/12, 02:38
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/272/ : SUCCESS -
Stanislas Rolland commented on patch set 2 01/21/12, 02:38
Abandoned