Review main Merged

41824[TASK] Implement EXT: resolving for iconfile option

Wouter Wolters CR +2 V +2 Normal +38 −30 updated 07/27/15, 07:08

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Frederic Gaus +1
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Susi Moog +1

Issues 1

Files 25

Show 5 more files

Review log 12

  1. Wouter Wolters uploaded patch set 1 07/22/15, 15:47

  2. Wouter Wolters commented on patch set 1 07/22/15, 15:48

    AbstractSpriteHandler.php:144

    not satisfied with this rtrim here.. anyone an idea if there is a function for this?
  3. Wouter Wolters uploaded patch set 2 07/22/15, 16:16

  4. Susi Moog commented on patch set 2 CR -1 07/22/15, 16:20

    AbstractSpriteHandler.php:144

    Should probably be done with PathUtility::dirname and PathUtility::basename to handle locale settings.
  5. Wouter Wolters uploaded patch set 3 07/22/15, 16:24

  6. Susi Moog voted on patch set 3 CR +1 07/23/15, 09:48

  7. Susi Moog commented on patch set 3 V +1 07/23/15, 09:52

    Can't vouch for the functional tests as a lot of them are failing on my machine, but tested manually the TCA stuff.
  8. Georg Ringer voted on patch set 3 CR +1 V +1 07/24/15, 07:20

  9. Frederic Gaus voted on patch set 3 CR +1 07/24/15, 11:22

  10. Benni Mack voted on patch set 3 CR +2 V +2 07/25/15, 09:01

  11. Benni Mack merged patch set 3 07/25/15, 09:01

  12. Mathias Brodala commented on patch set 4 07/27/15, 07:08

    Thanks for adding this FEATURE ;-)