41824[TASK] Implement EXT: resolving for iconfile option
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Frederic Gaus +1
- Georg Ringer +1
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
- Susi Moog +1
Issues 1
Files 25
- typo3/sysext/backend/Classes/Sprite/AbstractSpriteHandler.php2+10 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.php+5 −5
Show 5 more files
- typo3/sysext/impexp/Tests/Functional/Fixtures/Extensions/impexp_group_files/Configuration/TCA/tx_impexpgroupfiles_item.php+1 −1
- typo3/sysext/rtehtmlarea/Configuration/TCA/tx_rtehtmlarea_acronym.php+1 −1
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task_group.php+1 −1
- typo3/sysext/sys_action/Configuration/TCA/sys_action.php+1 −1
- typo3/sysext/sys_note/Configuration/TCA/sys_note.php+1 −1
Review log 12
-
Wouter Wolters uploaded patch set 1 07/22/15, 15:47
-
Wouter Wolters commented on patch set 1 07/22/15, 15:48
-
Wouter Wolters uploaded patch set 2 07/22/15, 16:16
-
Susi Moog commented on patch set 2 CR -1 07/22/15, 16:20
AbstractSpriteHandler.php:144Should probably be done with PathUtility::dirname and PathUtility::basename to handle locale settings. -
Wouter Wolters uploaded patch set 3 07/22/15, 16:24
-
Susi Moog voted on patch set 3 CR +1 07/23/15, 09:48
-
Susi Moog commented on patch set 3 V +1 07/23/15, 09:52
Can't vouch for the functional tests as a lot of them are failing on my machine, but tested manually the TCA stuff. -
Georg Ringer voted on patch set 3 CR +1 V +1 07/24/15, 07:20
-
Frederic Gaus voted on patch set 3 CR +1 07/24/15, 11:22
-
Benni Mack voted on patch set 3 CR +2 V +2 07/25/15, 09:01
-
Benni Mack merged patch set 3 07/25/15, 09:01
-
Mathias Brodala commented on patch set 4 07/27/15, 07:08
Thanks for adding this FEATURE ;-)
AbstractSpriteHandler.php:144