Review main Merged

41845Revert "[FEATURE] Fluid Tag Builder: Allow empty attributes"

Helmut Hummel CR +2 V +2 Normal +2 −62 updated 07/22/15, 18:46

Commit message

The change introduced is unfortunately broken conceptually and functionally.

For proper support of empty attributes, we must have the possibility to add
this functionality on an pre attribute basis to not interfere with attributes
which are not allowed to be specified in empty attribute syntax.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Marc Bastian Heinrichs +2
    • Markus Klein +1
  • Verified V +2
    • Helmut Hummel +2
    • Marc Bastian Heinrichs +2
    • Markus Klein +1

Issues 1

Files 5

Review log 8

  1. Helmut Hummel voted on patch set 1 CR +2 V +2 07/22/15, 18:38

  2. Marc Bastian Heinrichs updated the commit message in patch set 2 07/22/15, 18:44

  3. Marc Bastian Heinrichs voted on patch set 2 V +2 CR +2 07/22/15, 18:45

  4. Markus Klein updated the commit message in patch set 3 07/22/15, 18:45

  5. Markus Klein voted on patch set 3 CR +1 V +1 07/22/15, 18:45

  6. Helmut Hummel voted on patch set 3 CR +2 V +2 07/22/15, 18:45

  7. Marc Bastian Heinrichs voted on patch set 3 V +2 CR +2 07/22/15, 18:46

  8. Helmut Hummel merged patch set 3 07/22/15, 18:46