Review main Merged

41875[BUGFIX] Parser file not always an array in json_encode

Wouter Wolters CR +2 V +2 Easy +5 −12 updated 07/23/15, 17:50

Commit message

The parser file is not always an array. Instead it is a string.
In the end it is returned as json_encode.
This breaks the loading of the parser file.

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Goerz +1

Issues 1

Files 2

Review log 10

  1. Wouter Wolters uploaded patch set 1 07/23/15, 11:47

  2. Wouter Wolters updated the commit message in patch set 2 07/23/15, 11:50

  3. Susi Moog commented on patch set 2 V -1 07/23/15, 11:53

    This only fixes "half" the bug. Saving still does not work.
  4. Susi Moog commented on patch set 2 07/23/15, 11:54

    (save and close does not work, save does)
  5. Mathias Brodala commented on patch set 2 07/23/15, 11:57

    Can we mention t3editor somewhere? Otherwise one doesn't know what this change is about. ;-)
  6. Susi Moog commented on patch set 2 CR +1 V +1 07/23/15, 12:13

    extracted save and close to https://forge.typo3.org/issues/68487
  7. Daniel Goerz commented on patch set 2 V -1 07/23/15, 17:10

    Editing and saving works, but save&close button still does nothing for me.
  8. Daniel Goerz commented on patch set 2 V +1 CR +1 07/23/15, 17:16

    Never min. Works with https://review.typo3.org/#/c/41880/ applied.
  9. Susi Moog voted on patch set 2 CR +2 V +2 07/23/15, 17:50

  10. Susi Moog merged patch set 2 07/23/15, 17:50