Review main Merged

41880[BUGFIX] Save and close not working in file edit

Wouter Wolters CR +2 V +2 Easy +10 −2 updated 07/23/15, 17:52

Commit message

File edit for example a CSS file can't save and close.
The onclick event handler was removed completely.
This is wrong for save and close.

A wrong htmlspecialchars created a wrong URL for the redirect.

Both issues are solved with this commit.

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Goerz +1
    • Markus Klein +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Goerz +1
    • Markus Klein +1

Issues 1

Files 2

Review log 6

  1. Wouter Wolters uploaded patch set 1 07/23/15, 12:54

  2. Markus Klein voted on patch set 1 CR +1 07/23/15, 13:10

  3. Markus Klein voted on patch set 1 V +1 07/23/15, 13:24

  4. Daniel Goerz voted on patch set 1 CR +1 V +1 07/23/15, 17:17

  5. Susi Moog voted on patch set 1 CR +2 V +2 07/23/15, 17:52

  6. Susi Moog merged patch set 1 07/23/15, 17:52