Review main Merged

41937[TASK] Use GU::hmac() instead of encryption key in FileWriter

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 07/25/15, 07:03

Commit message

There is a potential attack to get hold of a secret encryption key
if such key is hashed with a single hash function and a small additional
string. So if you want to include the encryption key in an hash, you need
to *ALWAYS* use GeneralUtility::hmac() and not any different hash function.

Additionally, don't mention AdditionalConfiguration as place for config
manipulation, as it is considered a hack from core point of view
(see comment #52705).

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Alexander Stehlik +1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 9

  1. Anja Leichsenring uploaded patch set 1 07/24/15, 16:35

  2. Anja Leichsenring uploaded patch set 2 07/24/15, 16:52

  3. Anja Leichsenring uploaded patch set 3 07/24/15, 16:53

  4. Alexander Stehlik voted on patch set 3 CR +1 07/24/15, 16:58

  5. Helmut Hummel voted on patch set 3 CR +2 07/24/15, 17:02

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 07/24/15, 17:03

  7. Helmut Hummel voted on patch set 3 V +2 07/24/15, 17:03

  8. Helmut Hummel merged patch set 3 07/24/15, 17:03

  9. Xavier Perseguers commented on patch set 4 07/25/15, 07:03

    next time please be more precise and write either the link or something like "see review comment of #52705". Took me time to find those comments :)