Review main Merged

41964[BUGFIX] Improve styling of TS-Objectbrowsers edit view

Daniel Goerz CR +2 V +2 Easy +27 −16 updated 07/27/15, 10:00

Commit message

Bootsrap classes are applied to the form and the input fields
of the edit view in the objectbrowser to fit the rest of the
backend styling.
Additionally two unstyled a tags are transformed to buttons.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frank Nägler +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1

Issues 1

Files 5

Review log 8

  1. Daniel Goerz uploaded patch set 1 07/26/15, 08:58

  2. Stefan Froemken commented on patch set 1 07/27/15, 06:33

    The first input field for the key at "Add object property" is still smaller than the other fields.
  3. Daniel Goerz commented on patch set 1 07/27/15, 06:47

    > The first input field for the key at "Add object property" is still > smaller than the other fields. Yes I was not sure what to do with that field because it is kind of inline and imho it looks better the way it is than with bootrstrap styling. You think we should change it?
  4. Frank Nägler commented on patch set 1 CR -1 07/27/15, 08:11

    on it
  5. Frank Nägler uploaded patch set 2 07/27/15, 08:50

  6. Frank Nägler commented on patch set 2 CR +1 V +1 07/27/15, 08:53

    thx for you patch Daniel, I only changed the markup and removed the additional CSS, no need for extra margin with correct markup.
  7. Markus Klein voted on patch set 2 CR +2 V +2 07/27/15, 10:00

  8. Markus Klein merged patch set 2 07/27/15, 10:00