41977[BUGFIX] Adjusted tree components to align items of same level
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 24
-
Jo Hasenau uploaded patch set 1 07/27/15, 13:32
-
Jo Hasenau uploaded patch set 2 07/27/15, 14:18
-
Jo Hasenau commented on patch set 2 07/27/15, 14:20
Patchset 2 changed the last child position to match the other children. -
Nicole Hummel commented on patch set 2 07/27/15, 14:59
_element_tree.less:67Any reason why you have minored the padding here? Setting it back manually works as well and feels a bit more airy. -
Jo Hasenau commented on patch set 2 07/27/15, 16:01
_element_tree.less:67ReplyThe reason was that both parts should "give" something for the necessary adjustment. So on the one hand decreasing the padding for each of the items, while on the other hand adding space for the "non parents". The final result should consume about the same space as it did before otherwise we would lose one em of spacing per level. Of course this is not necessary for larger screens, but it might help with lower resolutions. -
Markus Klein commented on patch set 2 V -1 07/27/15, 18:01
still broken for me in configuration module -
Markus Klein commented on patch set 2 CR +1 V +1 07/27/15, 18:07
still some weird additional tree lines are rendered, but not related here. -
Frank Nägler commented on patch set 2 CR -1 07/27/15, 20:09
ArrayBrowser.php:112don't understand the trim here!? -
Wouter Wolters commented on patch set 2 07/27/15, 20:17
ArrayBrowser.php:112Replythis is done for the active class when there is no parent class set. -
Frank Nägler commented on patch set 2 CR 0 07/27/15, 20:25
ArrayBrowser.php:112Replywell ok, it is only prevent to prevent one empty space, which has no side effects. cosmetic source code... -
Nicole Hummel commented on patch set 2 07/27/15, 21:00
ArrayBrowser.php:112ReplyShould be done without the trim, but space after parent -
Jo Hasenau commented on patch set 2 07/28/15, 08:23
ArrayBrowser.php:112ReplyThe trim is just to make sure there will be no "class=" active" or class="parent " - but if you don't care, we can keep the space in the class attribute. -
Stefan Neufeind commented on patch set 2 CR +1 07/28/15, 10:27
_element_tree.less:67ReplyFine with me as proposed. Maybe have others have a final decision from design-perspective.ArrayBrowser.php:112ReplyI'm fine with the trim. Better than having the space too much or more complex solutions imho. -
Georg Ringer voted on patch set 2 CR +1 V +1 07/28/15, 11:54
-
Markus Klein voted on patch set 2 CR 0 V 0 07/28/15, 11:57
-
Stefan Neufeind voted on patch set 2 CR 0 07/28/15, 12:18
-
Jo Hasenau commented on patch set 2 07/28/15, 12:53
@Josef - IMHO the purpose of this issue has nothing to do with padding-right - so we have to leave that as is for now. Depending on which issue will be merged first, the other one will have to be rebased to make sure there is no regression. -
Jo Hasenau uploaded patch set 3 07/28/15, 13:03
-
Jo Hasenau commented on patch set 3 07/28/15, 13:04
New patchset just to make sure that the padding-right change will not override the removal of padding right in another patch. -
Benjamin Kott commented on patch set 3 CR -2 07/30/15, 22:21
is already solved in https://review.typo3.org/#/c/42145/ -
Jo Hasenau abandoned the change 07/31/15, 08:26
Superfluous now - so we don't need to keep it alive :-) -
Josef Glatz commented on patch set 2 CR -1 01/09/19, 20:56
_element_tree.less:40padding-right should not be added to all '.list-tree li .list-tree-group'. Please make shure that there is no UI regression anymore in the template module / TS Object Browser" and "info module / Page TSconfig". You find more details about at "https://forge.typo3.org/issues/68244#note-5"_element_tree.less:41This has an negative impact on the tree list in the template module (TS Object Browser) see screenshot: https://forge.typo3.org/issues/68507#note-6 and the page tree list within rte link wizard https://forge.typo3.org/issues/68507#note-7 -
Josef Glatz commented on patch set 3 CR -1 1 comment 01/09/19, 20:56
I would suggest either to correct all affected areas in the core related to this style changes or just apply this styles in the "configuration module context". -
Josef Glatz commented on patch set 3 01/09/19, 20:56
Due the reason that the close/open icons should be adopted to the new backend ui design, I would suggest to concentrate on that. This means that this patch/issue is (maybe) obsolete. (see https://review.typo3.org/#/c/42145/ or https://forge.typo3.org/issues/68649)