Review main Merged

41988[BUGFIX] Prevent double dots in data-table string for csh

Juan Manuel Vergés Solanas CR +2 V +2 Easy +6 −2 updated 07/27/15, 18:28

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 2

Review log 17

  1. Juan Manuel Vergés Solanas uploaded patch set 1 07/27/15, 17:18

  2. Juan Manuel Vergés Solanas uploaded patch set 2 07/27/15, 17:23

  3. Sascha Egerer commented on patch set 2 CR -1 07/27/15, 17:26

    Uppercase please

    FlexFormNoTabsContainer.php:72

    Space after if is missing. Should be `if ()`

    FlexFormTabsContainer.php:81

    Space also missing here
  4. Daniel Goerz updated the commit message in patch set 3 07/27/15, 17:28

  5. Sascha Egerer commented on patch set 2 07/27/15, 17:28

    FlexFormTabsContainer.php:81

    Space between ) and { also missing
  6. Juan Manuel Vergés Solanas uploaded patch set 4 07/27/15, 17:28

  7. Wouter Wolters voted on patch set 4 CR +1 07/27/15, 17:29

  8. Juan Manuel Vergés Solanas uploaded patch set 5 07/27/15, 17:35

  9. Sascha Egerer voted on patch set 5 CR +1 07/27/15, 17:45

  10. Wouter Wolters voted on patch set 5 CR +1 07/27/15, 17:45

  11. Markus Klein commented on patch set 5 07/27/15, 17:53

    FlexFormTabsContainer.php:81

    "0" might be a valid value, but empty() considers this as empty. IMO this must be if ((string)$row[$key] !== '')
  12. Juan Manuel Vergés Solanas uploaded patch set 6 07/27/15, 17:58

  13. Markus Klein commented on patch set 6 CR +1 V +1 07/27/15, 18:00

    looks good
  14. Wouter Wolters voted on patch set 6 CR +1 07/27/15, 18:01

  15. Andreas Kienast voted on patch set 6 CR +1 07/27/15, 18:26

  16. Wouter Wolters voted on patch set 6 V +2 CR +2 07/27/15, 18:28

  17. Wouter Wolters merged patch set 6 07/27/15, 18:28