41988[BUGFIX] Prevent double dots in data-table string for csh
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Andreas Kienast +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 2
Review log 17
-
Juan Manuel Vergés Solanas uploaded patch set 1 07/27/15, 17:18
-
Juan Manuel Vergés Solanas uploaded patch set 2 07/27/15, 17:23
-
Sascha Egerer commented on patch set 2 CR -1 07/27/15, 17:26
Uppercase pleaseFlexFormNoTabsContainer.php:72Space after if is missing. Should be `if ()`FlexFormTabsContainer.php:81Space also missing here -
Daniel Goerz updated the commit message in patch set 3 07/27/15, 17:28
-
Sascha Egerer commented on patch set 2 07/27/15, 17:28
FlexFormTabsContainer.php:81Space between ) and { also missing -
Juan Manuel Vergés Solanas uploaded patch set 4 07/27/15, 17:28
-
Wouter Wolters voted on patch set 4 CR +1 07/27/15, 17:29
-
Juan Manuel Vergés Solanas uploaded patch set 5 07/27/15, 17:35
-
Sascha Egerer voted on patch set 5 CR +1 07/27/15, 17:45
-
Wouter Wolters voted on patch set 5 CR +1 07/27/15, 17:45
-
Markus Klein commented on patch set 5 07/27/15, 17:53
FlexFormTabsContainer.php:81"0" might be a valid value, but empty() considers this as empty. IMO this must be if ((string)$row[$key] !== '') -
Juan Manuel Vergés Solanas uploaded patch set 6 07/27/15, 17:58
-
Markus Klein commented on patch set 6 CR +1 V +1 07/27/15, 18:00
looks good -
Wouter Wolters voted on patch set 6 CR +1 07/27/15, 18:01
-
Andreas Kienast voted on patch set 6 CR +1 07/27/15, 18:26
-
Wouter Wolters voted on patch set 6 V +2 CR +2 07/27/15, 18:28
-
Wouter Wolters merged patch set 6 07/27/15, 18:28