Review TYPO3_6-2 Merged

42017[BUGFIX] Catch exceptions for inaccessible storages

Alexander Opitz CR +2 V +2 Easy +39 −3 updated 08/12/15, 23:45

Commit message

A storage might be (temporary or permanently) not available in the
current file system. Then it should be displayed as inaccessible
(offline).
Catch all exceptions while trying to fetch permissions for any related
folders.
Only display paste icons for browsable storages.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Philipp Gampe +1

Issues 1

Files 6

Review log 17

  1. Christian Kuhn commented on patch set 1 CR -2 07/28/15, 09:12

    fails on master.
  2. Alexander Opitz uploaded patch set 2 07/28/15, 10:02

  3. Stefan Neufeind voted on patch set 2 CR +1 07/28/15, 10:09

  4. Christian Kuhn voted on patch set 2 CR 0 07/28/15, 12:06

  5. Alexander Opitz commented on patch set 2 CR -1 07/28/15, 12:11

    See Exception concerns from helhum for master.
  6. Stefan Neufeind voted on patch set 2 CR 0 07/28/15, 12:22

  7. Alexander Opitz uploaded patch set 3 07/28/15, 14:08

  8. Philipp Gampe commented on patch set 3 CR -1 07/28/15, 14:37

    Folder.php:375

    change here too?

    ResourceStorage.php:2663

    dito
  9. Philipp Gampe commented on patch set 3 07/28/15, 14:38

    btw, if you rename the exception, I would go for Resource\Driver\PermissionUnavailableException.
  10. Alexander Opitz uploaded patch set 4 07/28/15, 15:29

  11. Alexander Opitz commented on patch set 4 07/28/15, 15:31

  12. Philipp Gampe voted on patch set 4 CR +1 07/28/15, 15:37

  13. Philipp Gampe voted on patch set 4 V +1 07/28/15, 15:40

  14. Daniel Goerz voted on patch set 4 CR +1 08/12/15, 14:14

  15. Stefan Neufeind commented on patch set 4 08/12/15, 23:24

    Markus, could you maybe give this a try on 6.2 since you already checked it on master?
  16. Markus Klein voted on patch set 4 CR +2 V +2 08/12/15, 23:42

  17. Markus Klein merged patch set 4 08/12/15, 23:45