42017[BUGFIX] Catch exceptions for inaccessible storages
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Daniel Goerz +1
- Philipp Gampe +1
-
Verified V +2
- Markus Klein +2
- Philipp Gampe +1
Issues 1
Files 6
- typo3/sysext/backend/Classes/Utility/IconUtility.php+1 −0
- typo3/sysext/backend/Tests/Unit/Utility/IconUtilityTest.php+1 −0
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+5 −2
- typo3/sysext/core/Classes/Resource/Exception/ResourcePermissionsUnavailableException.phpnew+23 −0
- typo3/sysext/core/Classes/Resource/Folder.php1+5 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php1+4 −0
Review log 17
-
Christian Kuhn commented on patch set 1 CR -2 07/28/15, 09:12
fails on master. -
Alexander Opitz uploaded patch set 2 07/28/15, 10:02
-
Stefan Neufeind voted on patch set 2 CR +1 07/28/15, 10:09
-
Christian Kuhn voted on patch set 2 CR 0 07/28/15, 12:06
-
Alexander Opitz commented on patch set 2 CR -1 07/28/15, 12:11
See Exception concerns from helhum for master. -
Stefan Neufeind voted on patch set 2 CR 0 07/28/15, 12:22
-
Alexander Opitz uploaded patch set 3 07/28/15, 14:08
-
Philipp Gampe commented on patch set 3 CR -1 07/28/15, 14:37
Folder.php:375change here too?ResourceStorage.php:2663dito -
Philipp Gampe commented on patch set 3 07/28/15, 14:38
btw, if you rename the exception, I would go for Resource\Driver\PermissionUnavailableException. -
Alexander Opitz uploaded patch set 4 07/28/15, 15:29
-
Alexander Opitz commented on patch set 4 07/28/15, 15:31
Backport to 6.2 including follow-up https://review.typo3.org/#/c/42018/ https://review.typo3.org/#/c/42045/ -
Philipp Gampe voted on patch set 4 CR +1 07/28/15, 15:37
-
Philipp Gampe voted on patch set 4 V +1 07/28/15, 15:40
-
Daniel Goerz voted on patch set 4 CR +1 08/12/15, 14:14
-
Stefan Neufeind commented on patch set 4 08/12/15, 23:24
Markus, could you maybe give this a try on 6.2 since you already checked it on master? -
Markus Klein voted on patch set 4 CR +2 V +2 08/12/15, 23:42
-
Markus Klein merged patch set 4 08/12/15, 23:45