Review main Merged

42042[BUGFIX] Catch exceptions during extension update check

Nicole Hummel CR +2 V +2 Easy +6 −3 updated 09/09/15, 08:50

Commit message

For each extension the available update versions are checked. This
also tries to resolve the extension version dependencies according to
the current system. There might be updates which collide and
exceptions are thrown. This patch catches thrown exceptions as the
update check shouldn't break the Extension Manager.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Daniel Goerz +1
    • Markus Klein +1
    • Morton Jonuschat +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 22

  1. Nicole Hummel uploaded patch set 1 07/28/15, 14:05

  2. Wouter Wolters voted on patch set 1 CR +1 07/28/15, 14:35

  3. Stefan Neufeind voted on patch set 1 CR +1 07/28/15, 14:38

  4. Philipp Gampe voted on patch set 1 CR +1 07/28/15, 14:40

  5. Frederic Gaus voted on patch set 1 CR +1 07/30/15, 08:15

  6. Markus Klein commented on patch set 1 07/30/15, 10:47

    collide?
  7. Susi Moog commented on patch set 1 CR -1 08/05/15, 19:24

    I don't get which exceptions should be caught here, checkDependencies itself already catches and transforms exceptions itself, so afaics either that try catch block should be adjusted or there is a part throwing exceptions I did not find << if so please point me there ;)
  8. Susi Moog commented on patch set 1 08/07/15, 11:50

    Did try to reproduce it with the - non-installed - extensions mentioned in the forge ticket, I don't get an exception. I debugged it a bit and in master at least "hasDependencyErrors" is true but no exception is thrown as that is caught in the dependencyCheck itself. The try-catch-blocks there were integrated when you implemented the bypass-dependency-check thing. If you have time, let's compare code together - just trigger me on slack.
  9. Nicole Hummel commented on patch set 1 08/10/15, 17:44

    @Susi: Found another prerequisite - updated the forge ticket. Can reconstruct the exception even with master
  10. Morton Jonuschat commented on patch set 1 CR +1 08/28/15, 11:09

    I can't trigger any exception in the EM with the given set of extensions & versions.
  11. Morton Jonuschat commented on patch set 1 V +1 08/28/15, 13:38

    Finally managed to reproduce & verify
  12. Morton Jonuschat commented on patch set 1 08/28/15, 14:04

    @Susi, the extensions are triggered from DownloadQueue.php when two different extension request conflicting versions of the same dependency. (... was requested to be downloaded in different versions...)
  13. Morton Jonuschat commented on patch set 1 08/28/15, 14:04

    I meant Exceptions
  14. Susi Moog voted on patch set 1 CR +1 09/08/15, 05:00

  15. Markus Klein commented on patch set 1 09/08/15, 07:51

    Nicole, please check my comment on the commit message.
  16. Nicole Hummel updated the commit message in patch set 2 09/08/15, 08:40

  17. Markus Klein voted on patch set 2 CR +1 09/08/15, 09:10

  18. Stefan Neufeind voted on patch set 2 CR +1 09/08/15, 09:15

  19. Morton Jonuschat voted on patch set 2 CR +1 V +1 09/08/15, 18:22

  20. Daniel Goerz voted on patch set 2 CR +1 V +1 09/08/15, 18:53

  21. Christian Kuhn voted on patch set 2 CR +2 V +2 09/09/15, 08:50

  22. Christian Kuhn merged patch set 2 09/09/15, 08:50