Review main Merged

42043[TASK] Deactivate install tool core updater in composer mode

Helmut Hummel CR +2 V +2 Easy +14 −3 updated 07/28/15, 16:03

Commit message

Core updater must be disabled in composer mode,
to not interfere with composer commands.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 3

Review log 16

  1. Helmut Hummel uploaded patch set 1 07/28/15, 14:50

  2. Daniel Goerz voted on patch set 1 CR +1 07/28/15, 15:05

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 07/28/15, 15:06

  4. Markus Klein voted on patch set 1 CR +1 07/28/15, 15:32

  5. Wouter Wolters uploaded patch set 2 07/28/15, 15:33

  6. Wouter Wolters commented on patch set 2 V +1 CR +1 07/28/15, 15:35

    Please revote, I pushed an depedency by accident.
  7. Stefan Neufeind voted on patch set 2 CR +1 07/28/15, 15:42

  8. Markus Klein commented on patch set 2 CR +1 V +1 07/28/15, 15:51

    works in non-composer mode
  9. Markus Klein commented on patch set 2 V -1 CR -1 07/28/15, 15:52

    mistake in fluid
  10. Markus Klein commented on patch set 2 07/28/15, 15:53

    CoreUpdateButton.html:43

    comma missing
  11. Markus Klein commented on patch set 2 07/28/15, 15:53

    will push an update
  12. Markus Klein uploaded patch set 3 07/28/15, 15:59

  13. Markus Klein voted on patch set 3 CR +1 V +1 07/28/15, 16:00

  14. Stefan Neufeind commented on patch set 2 07/28/15, 16:02

    CoreUpdateButton.html:43 Reply

    Worked even without comma - hidden fluid-feature :-) But yes, thanks for pushing an update.
  15. Stefan Neufeind voted on patch set 3 CR +2 V +2 07/28/15, 16:03

  16. Stefan Neufeind merged patch set 3 07/28/15, 16:03