Review main Merged

42058[BUGFIX] Prefix font awesome icon path for admin_panel.css

Wouter Wolters CR +2 V +2 Easy +24 −18 updated 07/28/15, 19:30

Commit message

Font Awesome icons are prefixed with #TSFE_ADMIN_PANEL_FORM to
prevent issues with CSS from the website that uses Font Awesome too.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 2

Review log 11

  1. Wouter Wolters uploaded patch set 1 07/28/15, 16:57

  2. Markus Klein updated the commit message in patch set 2 07/28/15, 17:26

  3. Stefan Neufeind voted on patch set 2 CR +1 07/28/15, 17:30

  4. Wouter Wolters commented on patch set 2 V -1 CR -1 07/28/15, 17:41

    Working on it again
  5. Markus Klein commented on patch set 2 CR -1 07/28/15, 17:41

    this was split apart recently, due to mixture of adminpanel with feediting, see #61298
  6. Stefan Neufeind voted on patch set 2 CR -1 07/28/15, 17:46

  7. Wouter Wolters uploaded patch set 3 07/28/15, 17:48

  8. Markus Klein voted on patch set 3 CR +1 07/28/15, 18:17

  9. Stefan Neufeind voted on patch set 3 CR +1 07/28/15, 19:18

  10. Stefan Neufeind voted on patch set 3 CR +2 V +2 07/28/15, 19:30

  11. Stefan Neufeind merged patch set 3 07/28/15, 19:30