Review main Merged

42067[TASK] TS Object Browser: Add space to checkboxes

Josef Glatz CR +2 V +2 Easy +5 −6 updated 01/09/19, 20:56

Commit message

Add space between checkboxes and labels. Change
"typo3-listOptions" menu to gain the appearance of
the menu located in the list module.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Grein +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Grein +1

Issues 1

Files 2

Review log 9

  1. Josef Glatz uploaded patch set 1 01/09/19, 20:56

  2. Josef Glatz rebased onto patch set 1 01/09/19, 20:56

  3. Markus Klein commented on patch set 2 01/09/19, 20:56

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:478

    not used anymore then, please also remove the css
  4. Josef Glatz commented on patch set 2 01/09/19, 20:56

    If you didn't know what the patch should do take a look on forge https://forge.typo3.org/issues/68597#note-2
  5. Josef Glatz uploaded patch set 3 01/09/19, 20:56

  6. Markus Klein voted on patch set 4 CR +2 V +2 01/09/19, 20:56

  7. Alexander Grein voted on patch set 4 CR +1 V +1 01/09/19, 20:56

  8. Markus Klein merged patch set 4 01/09/19, 20:56

  9. Josef Glatz uploaded patch set 4 01/09/19, 20:56