Review main Merged

42068[TASK] Drop THIS_CID

Christian Kuhn CR +2 V +2 Easy +1 −21 updated 07/28/15, 18:45

Commit message

PageTsConfig can be configured to manipulate some queries in
the backend using marker based logic. One marker is THIS_CID
which refers to a record with field 'cid'. This field exists
nowhere and never did. The code dates back straight to Kaspers
initial subversion commit.
The only reference to this field is a german blog post stating
no further information can be found about this undocumented
feature.
Drop it.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 2

Review log 6

  1. Christian Kuhn uploaded patch set 1 07/28/15, 18:36

  2. Wouter Wolters voted on patch set 1 CR +1 07/28/15, 18:38

  3. Stefan Neufeind voted on patch set 1 CR +1 07/28/15, 18:39

  4. Daniel Goerz commented on patch set 1 CR +1 07/28/15, 18:42

    but, but, but ...
  5. Stefan Neufeind voted on patch set 1 CR +2 V +2 07/28/15, 18:44

  6. Stefan Neufeind merged patch set 1 07/28/15, 18:45