Review main Merged

42107[BUGFIX] Ignore configurable symlinks in structure check

Helmut Hummel CR +2 V +2 Hard +198 −186 updated 07/30/15, 09:20

Commit message

In composer mode the symlinks to index.php and typo3 are configurable
as well as the typo3_src folder is.

Ignore these links in the structure check in composer mode.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Frans Saris +1
  • Verified V +2
    • Frans Saris +2
    • Daniel Goerz +1

Issues 1

Files 4

Review log 12

  1. Helmut Hummel uploaded patch set 1 07/29/15, 16:59

  2. Frans Saris voted on patch set 1 CR +1 07/29/15, 17:02

  3. Markus Klein commented on patch set 1 CR +1 07/29/15, 17:22

    ListController.php:74

    this is still used multiple times in install tool
  4. Daniel Goerz voted on patch set 1 CR +1 V +1 07/29/15, 17:36

  5. Helmut Hummel uploaded patch set 2 07/29/15, 17:42

  6. Helmut Hummel commented on patch set 1 07/29/15, 17:43

    ListController.php:74 Reply

    ahh, thanks! missed them. I also somehow forgot last time that this is a static method. I updated all occurrences now
  7. Daniel Goerz voted on patch set 2 CR +1 V +1 07/29/15, 17:56

  8. Frans Saris commented on patch set 2 CR +1 V +1 07/29/15, 18:20

    tnx for the fix :)
  9. Benni Mack voted on patch set 2 CR +2 07/29/15, 18:21

  10. Frans Saris voted on patch set 2 V +2 07/29/15, 20:42

  11. Frans Saris merged patch set 2 07/29/15, 20:42

  12. Helmut Hummel commented on patch set 3 07/30/15, 09:20

    FYI: While talking with lolli, we agreed to revert this one again and implement a more general fix to the folder structure test