Review main Merged

42133[BUGFIX] ViewHelper variable container must deal with NULL

Andreas Treichel CR +2 V +2 Easy +25 −1 updated 08/05/15, 16:27

Commit message

The internal variable storage container for viewhelpers must
be capable of handling variables with NULL values.

Review

  • Code review CR +2
    • Susi Moog +2
    • Björn Fromme +1
  • Verified V +2
    • Susi Moog +2
    • Björn Fromme +1

Issues 1

Files 2

Review log 14

  1. Andreas Treichel uploaded patch set 1 07/30/15, 10:25

  2. Markus Klein commented on patch set 1 07/30/15, 10:52

    Thanks for your contribution. I'll update your patch to comply with CGL.
  3. Markus Klein uploaded patch set 2 07/30/15, 11:05

  4. Markus Klein voted on patch set 2 CR +1 07/30/15, 11:05

  5. Wouter Wolters commented on patch set 2 07/30/15, 11:10

    ViewHelperVariableContainer.php:94

    return isset($this->objects[$viewHelperName]) && array_key_exists($key, $this->objects[$viewHelperName]); is the solution from upstream.
  6. Markus Klein commented on patch set 2 07/30/15, 11:14

    ViewHelperVariableContainer.php:94 Reply

    well, I wasn't far away then. ;-)
  7. Markus Klein uploaded patch set 3 07/30/15, 11:15

  8. Markus Klein voted on patch set 3 CR +1 07/30/15, 11:15

  9. Wouter Wolters voted on patch set 3 CR +1 07/30/15, 11:15

  10. Susi Moog uploaded patch set 4 08/05/15, 16:21

  11. Susi Moog commented on patch set 4 CR +1 V +1 08/05/15, 16:22

    Added the tests from upstream
  12. Björn Fromme voted on patch set 4 CR +1 V +1 08/05/15, 16:25

  13. Susi Moog voted on patch set 4 CR +2 V +2 08/05/15, 16:27

  14. Susi Moog merged patch set 4 08/05/15, 16:27