42133[BUGFIX] ViewHelper variable container must deal with NULL
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Björn Fromme +1
-
Verified V +2
- Susi Moog +2
- Björn Fromme +1
Issues 1
Files 2
Review log 14
-
Andreas Treichel uploaded patch set 1 07/30/15, 10:25
-
Markus Klein commented on patch set 1 07/30/15, 10:52
Thanks for your contribution. I'll update your patch to comply with CGL. -
Markus Klein uploaded patch set 2 07/30/15, 11:05
-
Markus Klein voted on patch set 2 CR +1 07/30/15, 11:05
-
Wouter Wolters commented on patch set 2 07/30/15, 11:10
ViewHelperVariableContainer.php:94return isset($this->objects[$viewHelperName]) && array_key_exists($key, $this->objects[$viewHelperName]); is the solution from upstream. -
Markus Klein commented on patch set 2 07/30/15, 11:14
ViewHelperVariableContainer.php:94Replywell, I wasn't far away then. ;-) -
Markus Klein uploaded patch set 3 07/30/15, 11:15
-
Markus Klein voted on patch set 3 CR +1 07/30/15, 11:15
-
Wouter Wolters voted on patch set 3 CR +1 07/30/15, 11:15
-
Susi Moog uploaded patch set 4 08/05/15, 16:21
-
Susi Moog commented on patch set 4 CR +1 V +1 08/05/15, 16:22
Added the tests from upstream -
Björn Fromme voted on patch set 4 CR +1 V +1 08/05/15, 16:25
-
Susi Moog voted on patch set 4 CR +2 V +2 08/05/15, 16:27
-
Susi Moog merged patch set 4 08/05/15, 16:27