Review main Merged

42145[TASK] Pagetrees: adopt open/close icons and align items of same level

Josef Glatz CR +2 V +2 Hard +153 −113 updated 01/09/19, 20:56

Commit message

Adopt open/close icons for pagetrees (except for the main TYPO3 pagetree).
Fix width of last-child li's before-pseudo-element. Slightly adjust the
left padding for the filelist navigation frame. Introduce new open/close icons
for module configuration and module template "TS Object Browser".

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benjamin Kott +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Benjamin Kott +1

Issues 2

Files 4

Review log 13

  1. Josef Glatz commented on patch set 1 01/09/19, 20:56

    If you review, please be shure to test all affected areas in TYPO3 core. I mentioned them in the issue https://forge.typo3.org/issues/68649#Affected-areas-are-to-my-knowledge

    _element_tree.less:66

    Fix a bug, where the horizontal dotted dash on last-childs are too short

    _element_tree.less:81

    @Benjam: really gray boxes? (also for the element browser?)

    _element_tree.less:87

    Add new open/close icon styles

    _element_tree.less:98

    Reason: In some areas there is a "carret cursor".

    _element_tree.less:114

    Introduce boxed open/close icons for Template Module (TS Object Browser) and Configuration Module

    _element_tree.less:241

    We need a little bit more space here. The new open/close icon is a little bit wider now.
  2. Josef Glatz commented on patch set 1 1 comment 01/09/19, 20:56

  3. Josef Glatz uploaded patch set 1 01/09/19, 20:56

  4. Benjamin Kott commented on patch set 2 CR -1 01/09/19, 20:56

    working on it
  5. Markus Klein voted on patch set 3 V +1 01/09/19, 20:56

  6. Helmut Hummel voted on patch set 3 CR +2 V +2 01/09/19, 20:56

  7. Helmut Hummel merged patch set 3 01/09/19, 20:56

  8. Benjamin Kott uploaded patch set 3 01/09/19, 20:56

  9. Benjamin Kott commented on patch set 3 CR +1 V +1 01/09/19, 20:56

    EM have been replaced by PX values to make it more easy to control the dotted lines
  10. Benjamin Kott commented on patch set 4 01/09/19, 20:56

    oooopppsss, can take care on sunday if someone would like to correct this would be awesome
  11. Josef Glatz uploaded patch set 2 01/09/19, 20:56

  12. Josef Glatz commented on patch set 2 1 comment 01/09/19, 20:56

  13. Josef Glatz commented on patch set 4 01/09/19, 20:56

    The open/close arrow for root elements are gone after patch set 3. @Benjamin could you please check.