42145[TASK] Pagetrees: adopt open/close icons and align items of same level
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Benjamin Kott +1
-
Verified V +2
- Helmut Hummel +2
- Markus Klein +1
- Benjamin Kott +1
Issues 2
Files 4
Review log 13
-
Josef Glatz commented on patch set 1 01/09/19, 20:56
If you review, please be shure to test all affected areas in TYPO3 core. I mentioned them in the issue https://forge.typo3.org/issues/68649#Affected-areas-are-to-my-knowledge_element_tree.less:66Fix a bug, where the horizontal dotted dash on last-childs are too short_element_tree.less:81@Benjam: really gray boxes? (also for the element browser?)_element_tree.less:87Add new open/close icon styles_element_tree.less:98Reason: In some areas there is a "carret cursor"._element_tree.less:114Introduce boxed open/close icons for Template Module (TS Object Browser) and Configuration Module_element_tree.less:241We need a little bit more space here. The new open/close icon is a little bit wider now. -
Josef Glatz commented on patch set 1 1 comment 01/09/19, 20:56
-
Josef Glatz uploaded patch set 1 01/09/19, 20:56
-
Benjamin Kott commented on patch set 2 CR -1 01/09/19, 20:56
working on it -
Markus Klein voted on patch set 3 V +1 01/09/19, 20:56
-
Helmut Hummel voted on patch set 3 CR +2 V +2 01/09/19, 20:56
-
Helmut Hummel merged patch set 3 01/09/19, 20:56
-
Benjamin Kott uploaded patch set 3 01/09/19, 20:56
-
Benjamin Kott commented on patch set 3 CR +1 V +1 01/09/19, 20:56
EM have been replaced by PX values to make it more easy to control the dotted lines -
Benjamin Kott commented on patch set 4 01/09/19, 20:56
oooopppsss, can take care on sunday if someone would like to correct this would be awesome -
Josef Glatz uploaded patch set 2 01/09/19, 20:56
-
Josef Glatz commented on patch set 2 1 comment 01/09/19, 20:56
-
Josef Glatz commented on patch set 4 01/09/19, 20:56
The open/close arrow for root elements are gone after patch set 3. @Benjamin could you please check.