42156[TASK] Improve styling of Element Information popup
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Benjamin Kott +1
-
Verified V +2
- Frank Nägler +2
- Benjamin Kott +1
Issues 1
Files 3
Review log 16
-
Markus Klein uploaded patch set 2 01/09/19, 20:56
-
Markus Klein commented on patch set 2 01/09/19, 20:56
the avatar is still not perfectly centered -
Benjamin Kott commented on patch set 2 CR -2 01/09/19, 20:56
No Changes to die Avatar CSS! This one is done. Like done, done, done. If space to the right is missing add a blank please. Vertical alignment is middle, if there is a placement problem its about the surroundings nicht the avatar! -
Josef Glatz uploaded patch set 1 01/09/19, 20:56
-
Josef Glatz commented on patch set 2 01/09/19, 20:56
Thx Benji. It first I thought about the twb media-object. But it has some strange behaviour within a table-cell. hmm -
Oliver Hader uploaded patch set 4 01/09/19, 20:56
-
Michael Oehlhof voted on patch set 4 CR +1 V +1 01/09/19, 20:56
-
Benjamin Kott commented on patch set 4 01/09/19, 20:56
short feedback on this - got this on my list but i dislike the current solution having in mind that we need to migrate to bootstrap 4 at some point i would like to see a backport of: http://v4-alpha.getbootstrap.com/components/utilities/#margin this will ease the migration and is far more flexible if someone is interested in doing this, feel free to add a new component for this. else please wait until i got time to do it at the weekend. -
Frank Nägler voted on patch set 5 CR +2 V +2 01/09/19, 20:56
-
Benjamin Kott uploaded patch set 5 01/09/19, 20:56
-
Benjamin Kott voted on patch set 5 CR +1 V +1 01/09/19, 20:56
-
Daniel Goerz commented on patch set 3 01/09/19, 20:56
What is the status here? -
Daniel Goerz voted on patch set 4 CR 0 V 0 01/09/19, 20:56
-
Daniel Goerz commented on patch set 4 CR +1 V +1 01/09/19, 20:56
Avaters CSSis no longer touched. You may unblock this one ;) -
Frank Nägler merged patch set 5 01/09/19, 20:56
-
Josef Glatz uploaded patch set 3 01/09/19, 20:56