4220[BUGFIX] t3lib_tcemain unset empty fields even if a lower range is set
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 18
-
Björn Pedersen commented on patch set 1 05/24/12, 16:32
I would prefer that you didn't submit this Reading the code, you could actually achieve your goal without patch by setting either default or checkbox value. -
Björn Pedersen commented on patch set 1 05/24/12, 16:32
This still seems problematic to me: In your use case, it is correct, as you want to allow an empty field as well. But others may want a strict limit and disallow empty fields. maybe we need an additional flag wether an empty string is acceptable as well? -
Markus Klein commented on patch set 1 05/24/12, 16:32
So this is more a regression?And now also for 4.7 -
Markus Klein commented on patch set 1 05/24/12, 16:32
(1 inline comment) -
Markus Klein commented on patch set 1 05/24/12, 16:32
Verified; Looks good to me, but someone else must approve This is definitely a regression for 4.5 and 4.6!!! The unknowing user clears the field, hits the save & close button and wonders why the record didn't change. -
Markus Klein commented on patch set 2 05/24/12, 16:32
Verified; Looks good to me, but someone else must approve Why R:-1 Oliver? -
Björn Pedersen commented on patch set 3 05/24/12, 16:32
I would prefer that you didn't submit this I still think this behaviuour needs a configurable switch, otherwise you can not force non-empty fields here. -
Markus Klein uploaded patch set 3 05/24/12, 16:32
-
Markus Klein commented on patch set 3 05/24/12, 16:32
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 3 05/24/12, 16:32
Fails; I would prefer that you didn't submit this Resolved by https://review.typo3.org/7624 Abandon please. -
Oliver Hader uploaded patch set 2 05/24/12, 16:32
-
Oliver Hader commented on patch set 2 05/24/12, 16:32
Verified; I would prefer that you didn't submit this Rebasing to master V:1, R:-1 V:0, R:-1 from Björn Pedersen <bjoern.pedersen@frm2.tum.de> V:1, R:1 from Markus Klein <klein.t3@mfc-linz.at> -
Oliver Hader commented on patch set 3 05/24/12, 16:32
@Markus: This was an automated script that just rebased the existing changes (due to the new submodules this might produce errors on cherry-picking a change and thus might frighten some devs). The script just collected the previous votes and re-applied that again - which seems to be a confusing and bad idea. -
Alienor.net commented on patch set 1 05/24/12, 16:32
Björn, I understand what you're saying, and yes it is totally feasible to change an extension's TCA to meet this goal, but the problem is that it is a problem for nearly all existing extensions based on the kickstarter, and that the change (introduced in 4.5) breaks retrocompatibility for those extensions, without a clear gain. -
Mr. Jenkins commented on patch set 1 05/24/12, 16:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1601/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/24/12, 16:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2689/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/24/12, 16:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2701/ : SUCCESS -
Steffen Gebert commented on patch set 3 05/24/12, 16:32
Abandoned