Review main Merged

42203[TASK] Update Symfony components to current LTS version

Patrik Karisch CR +2 V +2 Easy +25 −23 updated 08/07/15, 16:56

Commit message

Allow the current Symfony LTS version for components. 2.5 is out of
date and 2.6 will be soon.

Update composer.lock for all symfony components to be consistent.

Update our code a bit to not trigger deprecation errors,

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Helmut Hummel +2
    • Patrik Karisch +1
  • Verified V +2
    • Wouter Wolters +2
    • Helmut Hummel +2

Issues 1

Files 3

Review log 20

  1. Patrik Karisch uploaded patch set 1 08/01/15, 14:41

  2. Frans Saris voted on patch set 1 CR +1 08/01/15, 15:11

  3. Frans Saris commented on patch set 1 08/01/15, 15:13

    What about doctrine and swiftmailer. Maybe we should do the same for those dependencies
  4. Patrik Karisch commented on patch set 1 08/01/15, 15:21

    > What about doctrine and swiftmailer. Maybe we should do the same > for those dependencies Would be good too. In a separate change or here?
  5. Frans Saris commented on patch set 1 08/01/15, 16:05

    Same patch is ok
  6. Helmut Hummel commented on patch set 1 CR -1 08/01/15, 16:15

    > What about doctrine and swiftmailer. Maybe we should do the same for those dependencies We decided to not do that. Updates of third party libraries should not change for minor version and by changing the composer.json like that would deliver different versions of the libraries (even different minor versions) to composer users
  7. Patrik Karisch commented on patch set 1 08/01/15, 16:37

    I would like to update only for symfony in this change, not the others. Btw. are doctrine and swiftmailer constraints the newest minor releases, so a change doesn't take effect.
  8. Patrik Karisch uploaded patch set 2 08/01/15, 16:48

  9. Helmut Hummel commented on patch set 2 CR -1 08/01/15, 16:56

    we need to check if our symfony/console code is compatible with the upgrade
  10. Patrik Karisch commented on patch set 2 08/01/15, 17:22

    > we need to check if our symfony/console code is compatible with the > upgrade There are now BC breaks. Only bugfixes, new helpers (already in 2.5) and some new method signatures with default values to be backwards compatible. As said in slack the current code which uses the console component is not affected, but it uses already deprected helpers. But this would be subjected to another change. See https://forge.typo3.org/issues/68690
  11. Patrik Karisch commented on patch set 2 08/01/15, 17:22

    *no BC breaks
  12. Frank Nägler commented on patch set 2 CR -1 08/01/15, 17:59

    I agree to Helmut, I have the same concerns.
  13. Sascha Egerer updated the commit message in patch set 3 08/03/15, 06:54

  14. Frank Nägler commented on patch set 3 CR -1 08/03/15, 07:06

    the concerns from patchset2 are still valid.
  15. Benni Mack commented on patch set 3 CR +1 08/07/15, 12:09

    I think this is fine for now
  16. Helmut Hummel uploaded patch set 4 08/07/15, 15:56

  17. Helmut Hummel commented on patch set 4 CR +2 V +2 08/07/15, 15:59

    I checked our usages and disabled deprecation messages. Until we change something conceptually, I think this is good and fine to raise versions to supported LTS version
  18. Patrik Karisch commented on patch set 4 CR +1 08/07/15, 16:02

    Wui, the deprecation warnings were not niffty. Thx.
  19. Wouter Wolters voted on patch set 4 V +2 CR +2 08/07/15, 16:56

  20. Wouter Wolters merged patch set 4 08/07/15, 16:56