Review main Merged

42209[BUGFIX] Moved transferDeprecatedCurlSettings from Bootstrap to Setup

Michael Oehlhof CR +2 V +2 Hard +241 −105 updated 08/08/15, 15:15

Commit message

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1

Issues 1

Files 4

Review log 14

  1. Michael Oehlhof uploaded patch set 1 08/02/15, 22:08

  2. Michael Oehlhof commented on patch set 1 V -1 08/02/15, 22:26

    Have to move the unit test also ...
  3. Michael Oehlhof uploaded patch set 2 08/07/15, 23:00

  4. Christian Kuhn updated the commit message in patch set 3 08/08/15, 13:28

  5. Wouter Wolters commented on patch set 3 08/08/15, 13:56

    SilentConfigurationUpgradeServiceTest.php:6

    one tab too much here
  6. Wouter Wolters uploaded patch set 4 08/08/15, 14:18

  7. Wouter Wolters voted on patch set 4 V +1 CR +1 08/08/15, 14:18

  8. Christian Kuhn commented on patch set 4 CR -1 08/08/15, 15:00

    SilentConfigurationUpgradeService.php:300

    triggers an infinite loop.
  9. Christian Kuhn uploaded patch set 5 08/08/15, 15:05

  10. Christian Kuhn uploaded patch set 6 08/08/15, 15:10

  11. Susi Moog voted on patch set 5 CR +1 V +1 08/08/15, 15:10

  12. Christian Kuhn voted on patch set 6 CR +1 V +1 08/08/15, 15:14

  13. Susi Moog voted on patch set 6 CR +2 V +2 08/08/15, 15:14

  14. Susi Moog merged patch set 6 08/08/15, 15:15