42210[FOLLOWUP][TASK] Pagetrees: adopt open/close icons and align items of same level
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Benjamin Kott +1
-
Verified V +2
- Georg Ringer +2
- Benjamin Kott +1
Issues 1
Files 12
- Build/Resources/Public/Less/TYPO3/_element_rte.less+0 −5
- Build/Resources/Public/Less/TYPO3/_element_tree.less1+60 −25
- Build/Resources/Public/Less/TYPO3/_main_body.less+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+7 −2
- typo3/sysext/backend/Classes/Tree/View/ElementBrowserPageTreeView.php+9 −4
- typo3/sysext/backend/Classes/View/PageTreeView.php+2 −2
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+6 −3
- typo3/sysext/filelist/Classes/FileListFolderTree.php+2 −2
- typo3/sysext/lowlevel/Classes/Utility/ArrayBrowser.php+1 −2
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+42 −15
- typo3/sysext/rtehtmlarea/Classes/PageTree.php+10 −3
- typo3/sysext/t3skin/Resources/Public/Css/backend.css1+55 −35
Review log 29
Show 4 earlier messages
-
Sascha Egerer commented on patch set 2 CR -1 01/09/19, 20:56
backend.css:10900? Half pixels? -
Frank Nägler updated the commit message in patch set 2 01/09/19, 20:56
-
Frank Nägler voted on patch set 2 V +1 01/09/19, 20:56
-
Frank Nägler commented on patch set 2 CR +1 01/09/19, 20:56
I can't see any different between core and this patch. Who to test this fix?
-
Frank Nägler commented on patch set 2 01/09/19, 20:56
How can I test it? -
Josef Glatz uploaded patch set 1 01/09/19, 20:56
-
Josef Glatz commented on patch set 1 01/09/19, 20:56
Please review all affected areas (see ticket). What this patch should do: https://youtu.be/jjED7kWy0Rg (before/after) ;-) -
Josef Glatz commented on patch set 2 01/09/19, 20:56
@Frank: https://youtu.be/jjED7kWy0Rg (before/after) -
Sascha Egerer voted on patch set 3 CR -1 1 comment 01/09/19, 20:56
-
Josef Glatz uploaded patch set 3 01/09/19, 20:56
-
Josef Glatz commented on patch set 3 01/09/19, 20:56
Thx for your feedback. New patch set to review :-) -
Josef Glatz uploaded patch set 4 01/09/19, 20:56
-
Josef Glatz uploaded patch set 5 01/09/19, 20:56
-
Ralf Merz voted on patch set 6 CR +1 V +1 01/09/19, 20:56
-
Wouter Wolters voted on patch set 6 V +1 CR +1 01/09/19, 20:56
-
Josef Glatz uploaded patch set 6 01/09/19, 20:56
-
Josef Glatz commented on patch set 6 01/09/19, 20:56
Sorry folks for pushing another patch. Now the calculated values are rounded to whole numbers. -
Stefan Neufeind voted on patch set 7 CR +1 01/09/19, 20:56
-
Andreas Kienast voted on patch set 7 CR +1 01/09/19, 20:56
-
Josef Glatz uploaded patch set 7 01/09/19, 20:56
-
Ralf Merz voted on patch set 8 CR +1 V +1 01/09/19, 20:56
-
Jigal van Hemert voted on patch set 8 CR +1 V +1 01/09/19, 20:56
-
Wouter Wolters commented on patch set 8 V +1 CR +1 01/09/19, 20:56
Please allow Benjamin Kott to have a look at this in the evening. -
Georg Ringer voted on patch set 9 CR +2 V +2 01/09/19, 20:56
-
Benjamin Kott uploaded patch set 9 01/09/19, 20:56
-
Benjamin Kott commented on patch set 9 CR +1 V +1 01/09/19, 20:56
well, there is currenlty no constistent generated markup for trees based on css, tried to clean it up as much as possible but rte insert link file/folder still looks shitty. markup change is also needed here, sadly i have to do to bed now and will have no time do work on it till tomorrow evening. however the problem is solved for now as far as i tested so we can get this in and make the file stuffy more streamlined after 7.4 release. -
Andreas Kienast voted on patch set 8 CR +1 01/09/19, 20:56
-
Georg Ringer merged patch set 9 01/09/19, 20:56
-
Josef Glatz uploaded patch set 8 01/09/19, 20:56
_element_tree.less:156