Review main Merged

42210[FOLLOWUP][TASK] Pagetrees: adopt open/close icons and align items of same level

Josef Glatz CR +2 V +2 Hard +195 −99 updated 01/09/19, 20:56

Commit message

Let the open/close icons for the tree root elements reappear.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benjamin Kott +1
  • Verified V +2
    • Georg Ringer +2
    • Benjamin Kott +1

Issues 1

Files 12

Review log 29

Show 4 earlier messages
  1. Sascha Egerer commented on patch set 2 CR -1 01/09/19, 20:56

    _element_tree.less:156

    Do we need also a "ceil()" here?

    backend.css:10900

    ? Half pixels?
  2. Frank Nägler updated the commit message in patch set 2 01/09/19, 20:56

  3. Frank Nägler voted on patch set 2 V +1 01/09/19, 20:56

  4. Frank Nägler commented on patch set 2 CR +1 01/09/19, 20:56

    I can't see any different between core and this patch. Who to test this fix?
  1. Frank Nägler commented on patch set 2 01/09/19, 20:56

    How can I test it?
  2. Josef Glatz uploaded patch set 1 01/09/19, 20:56

  3. Josef Glatz commented on patch set 1 01/09/19, 20:56

    Please review all affected areas (see ticket). What this patch should do: https://youtu.be/jjED7kWy0Rg (before/after) ;-)
  4. Josef Glatz commented on patch set 2 01/09/19, 20:56

    @Frank: https://youtu.be/jjED7kWy0Rg (before/after)
  5. Sascha Egerer voted on patch set 3 CR -1 1 comment 01/09/19, 20:56

  6. Josef Glatz uploaded patch set 3 01/09/19, 20:56

  7. Josef Glatz commented on patch set 3 01/09/19, 20:56

    Thx for your feedback. New patch set to review :-)
  8. Josef Glatz uploaded patch set 4 01/09/19, 20:56

  9. Josef Glatz uploaded patch set 5 01/09/19, 20:56

  10. Ralf Merz voted on patch set 6 CR +1 V +1 01/09/19, 20:56

  11. Wouter Wolters voted on patch set 6 V +1 CR +1 01/09/19, 20:56

  12. Josef Glatz uploaded patch set 6 01/09/19, 20:56

  13. Josef Glatz commented on patch set 6 01/09/19, 20:56

    Sorry folks for pushing another patch. Now the calculated values are rounded to whole numbers.
  14. Stefan Neufeind voted on patch set 7 CR +1 01/09/19, 20:56

  15. Andreas Kienast voted on patch set 7 CR +1 01/09/19, 20:56

  16. Josef Glatz uploaded patch set 7 01/09/19, 20:56

  17. Ralf Merz voted on patch set 8 CR +1 V +1 01/09/19, 20:56

  18. Jigal van Hemert voted on patch set 8 CR +1 V +1 01/09/19, 20:56

  19. Wouter Wolters commented on patch set 8 V +1 CR +1 01/09/19, 20:56

    Please allow Benjamin Kott to have a look at this in the evening.
  20. Georg Ringer voted on patch set 9 CR +2 V +2 01/09/19, 20:56

  21. Benjamin Kott uploaded patch set 9 01/09/19, 20:56

  22. Benjamin Kott commented on patch set 9 CR +1 V +1 01/09/19, 20:56

    well, there is currenlty no constistent generated markup for trees based on css, tried to clean it up as much as possible but rte insert link file/folder still looks shitty. markup change is also needed here, sadly i have to do to bed now and will have no time do work on it till tomorrow evening. however the problem is solved for now as far as i tested so we can get this in and make the file stuffy more streamlined after 7.4 release.
  23. Andreas Kienast voted on patch set 8 CR +1 01/09/19, 20:56

  24. Georg Ringer merged patch set 9 01/09/19, 20:56

  25. Josef Glatz uploaded patch set 8 01/09/19, 20:56