42228[BUGFIX] Mod InfoPageTSConfig: Remove colon in label "Sort alphabetically"
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Daniel Goerz +1
- Xavier Perseguers +1
-
Verified V +2
- Susi Moog +2
- Daniel Goerz +1
- Xavier Perseguers +1
Issues 1
Files 2
Review log 11
-
Daniel Maier commented on patch set 1 V -1 01/09/19, 20:56
IMHO changing the translated string would be the way to go in that case (remove the colon). Regarding user experience it's better to have the checkbox before the text. -
Xavier Perseguers commented on patch set 2 CR -2 01/09/19, 20:56
Not yet ready, still blank space missing at the beginning, will come up with a fix -
Xavier Perseguers voted on patch set 2 CR -1 01/09/19, 20:56
-
Susi Moog voted on patch set 3 CR +2 V +2 01/09/19, 20:56
-
Xavier Perseguers voted on patch set 3 CR +1 V +1 01/09/19, 20:56
-
Xavier Perseguers uploaded patch set 3 01/09/19, 20:56
-
Daniel Maier uploaded patch set 2 01/09/19, 20:56
-
Daniel Goerz voted on patch set 3 CR +1 V +1 01/09/19, 20:56
-
Susi Moog merged patch set 3 01/09/19, 20:56
-
Josef Glatz commented on patch set 1 01/09/19, 20:56
A better solution than changing the order in the markup is to update translated strings. It would be more natural if the checkbox is left and label right. Do anybody if it is possible to change a string on translation.typo3.org just for e.g. TYPO3 v7? -
Josef Glatz uploaded patch set 1 01/09/19, 20:56