Review main Merged

42229[BUGFIX] Fix inclusion of non existing favion in Install Tool

Georg Ringer CR +2 V +2 Easy +0 −1 updated 08/03/15, 22:28

Commit message

Remove the usage of a non existing favicon in the Install Tool.
As this should be rather standalone, removal is preferred over
including files of EXT:backend.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 10

  1. Georg Ringer uploaded patch set 1 08/03/15, 19:13

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 08/03/15, 19:22

  3. Stefan Neufeind commented on patch set 1 CR +1 08/03/15, 19:48

    We don't want to use the favicon at typo3/sysext/backend/Resources/Public/Icons/favicon.ico do we? That would add a "dependency" from EXT:install to EXT:backend, sort of. I'm fine with not having a favicon there.
  4. Stefan Neufeind commented on patch set 1 08/03/15, 19:50

    or copy the ico over to EXT:install maybe?
  5. Stefan Neufeind commented on patch set 1 08/03/15, 19:52

    "usage" is preferred? you mean the removal is preferred?
  6. Christian Kuhn commented on patch set 1 CR +1 08/03/15, 20:10

    fine with not having favicon.
  7. Georg Ringer updated the commit message in patch set 2 08/03/15, 20:12

  8. Wouter Wolters voted on patch set 2 V +1 CR +1 08/03/15, 20:16

  9. Benni Mack voted on patch set 2 CR +2 V +2 08/03/15, 22:27

  10. Benni Mack merged patch set 2 08/03/15, 22:28