42229[BUGFIX] Fix inclusion of non existing favion in Install Tool
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2
- Benni Mack +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 10
-
Georg Ringer uploaded patch set 1 08/03/15, 19:13
-
Wouter Wolters voted on patch set 1 V +1 CR +1 08/03/15, 19:22
-
Stefan Neufeind commented on patch set 1 CR +1 08/03/15, 19:48
We don't want to use the favicon at typo3/sysext/backend/Resources/Public/Icons/favicon.ico do we? That would add a "dependency" from EXT:install to EXT:backend, sort of. I'm fine with not having a favicon there. -
Stefan Neufeind commented on patch set 1 08/03/15, 19:50
or copy the ico over to EXT:install maybe? -
Stefan Neufeind commented on patch set 1 08/03/15, 19:52
"usage" is preferred? you mean the removal is preferred? -
Christian Kuhn commented on patch set 1 CR +1 08/03/15, 20:10
fine with not having favicon. -
Georg Ringer updated the commit message in patch set 2 08/03/15, 20:12
-
Wouter Wolters voted on patch set 2 V +1 CR +1 08/03/15, 20:16
-
Benni Mack voted on patch set 2 CR +2 V +2 08/03/15, 22:27
-
Benni Mack merged patch set 2 08/03/15, 22:28