Review main Merged

42232[FOLLOWUP][TASK] Pagetrees: adopt open/close icons and align items of same level

Josef Glatz CR +2 V +2 Easy +3 −1 updated 01/09/19, 20:56

Commit message

Module Filelist -> Folder Tree: prevents the line break between icon and text.
Element Browser: Missing space between tree item text and .list-tree-show icon added.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Stefan Neufeind +1
    • Alexander Grein +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Stefan Neufeind +1
    • Alexander Grein +1
    • Christian Kuhn +1

Issues 1

Files 3

Review log 14

  1. Ralf Merz voted on patch set 1 CR +1 01/09/19, 20:56

  2. Benjamin Kott commented on patch set 1 01/09/19, 20:56

    do not get where the pull right comes up again, as i remember i removed it this night and introduced list-tree-show instead
  3. Josef Glatz uploaded patch set 1 01/09/19, 20:56

  4. Josef Glatz commented on patch set 1 01/09/19, 20:56

    During testing of https://review.typo3.org/42210 I noticed these little no-brainers (one of it was previously already solved). I was too slow, the patch was already merged, so I have to push another followup here :-)
  5. Benjamin Kott commented on patch set 2 CR +1 01/09/19, 20:56

    Looks good on read
  6. Josef Glatz uploaded patch set 2 01/09/19, 20:56

  7. Josef Glatz rebased onto patch set 2 01/09/19, 20:56

  8. Stefan Neufeind voted on patch set 3 CR +1 01/09/19, 20:56

  9. Stefan Neufeind voted on patch set 3 V +1 01/09/19, 20:56

  10. Alexander Grein voted on patch set 3 CR +1 V +1 01/09/19, 20:56

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 01/09/19, 20:56

  12. Andreas Kienast voted on patch set 3 CR +1 V +1 01/09/19, 20:56

  13. Andreas Kienast voted on patch set 3 CR +2 V +2 01/09/19, 20:56

  14. Andreas Kienast merged patch set 3 01/09/19, 20:56