Review TYPO3_4-5 Abandoned

4225[BUGFIX] Unprivileged backend user can read arbitrarily from database (backwards-compatible fix)

Michael Stucki CR 0 V 0 Easy +22 −0 updated 06/03/13, 20:49

Commit message

Strip any "{...}" instructions from content except those which are
specified by a whitelist (and thus considered as safe).
The new "insertData.whitelist" property is an internal helper and is not
available for public use. It won't be added to future versions!

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 11

  1. Michael Stucki uploaded patch set 2 08/10/11, 16:12

  2. Michael Stucki commented on patch set 2 08/10/11, 16:12

    Yes, that's my suggestion (if the RMs agree...)
  3. Francois Suter commented on patch set 2 08/10/11, 16:12

    Fails That won't help for people who have already switched from fontTag to dataWrap. They will be back to have a double wrap.
  4. Francois Suter commented on patch set 2 08/10/11, 16:12

    I would prefer that you didn't submit this
  5. Stefan Neufeind commented on patch set 2 08/10/11, 16:12

    Looks good to me, but someone else must approve Should this get a Releases: 4.3, 4.4, 4.5 then?
  6. Helmut Hummel commented on patch set 2 08/10/11, 16:12

    No score @Francois: the change in the compatibility setup was not released (because we forgot it), we committed this _after_ the release. So this would help people having one of the compatibility setup enabled, which would run into the problem in 4.5.5
  7. Helmut Hummel commented on patch set 2 08/10/11, 16:12

    I would prefer that you didn't submit this Please look at https://review.typo3.org/4230 for my suggestion I could not push into this changeset, as you added a dependency to https://review.typo3.org/4223
  8. Georg Ringer commented on patch set 2 08/10/11, 16:12

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 08/10/11, 16:12

  10. Mr. Jenkins commented on patch set 2 08/10/11, 16:12

  11. Michael Stucki commented on patch set 2 08/10/11, 16:12

    Abandoned Abandoned in favour of https://review.typo3.org/4230