42272[CLEANUP] Rename AbstractContentObject::getContentObject()
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Benni Mack +1
-
Verified V +2
- Andreas Wolf +2
- Benni Mack +1
Issues 1
Files 3
Review log 30
Show 5 earlier messages
-
Elmar Hinz uploaded patch set 1 08/05/15, 11:39
-
Mathias Brodala uploaded patch set 2 08/05/15, 11:59
-
Mathias Brodala commented on patch set 2 08/05/15, 12:00
-
Wouter Wolters commented on patch set 2 CR -1 08/05/15, 12:05
1. I don't see any benefit in changing the name. 2. What is exactly breaking? Marking the commit with [!!!] means there breaks something but a deprecation doesn't break anything. 3. If this is accepted there needs to be an RST file that explains the deprecation. typo3/sysext/core/Documentation/ contains alot of examples. 4. The core should not use any deprecated methods. All core calls need to be adapted too. -
Elmar Hinz commented on patch set 2 08/05/15, 13:21
1. The benefit is clearness of the wording. No, less, no more. You call getMilk and a cow is delivered? I gonna update 2. 3. 4.
-
Christian Kuhn voted on patch set 2 CR -1 08/05/15, 13:55
-
Wouter Wolters commented on patch set 2 CR -2 08/05/15, 14:55
I discussed this with some people and the conclusion is that we don't gain anything here, only work for extension developers that use this method. Only a name change is not worth the hassle without having a tool that can do automatic migration of deprecated methods in your extension code. See also https://forge.typo3.org/issues/68175 for the story behind this. -
Elmar Hinz commented on patch set 2 08/05/15, 15:09
@wouter: The extensions is the reason why I set the deprecation range to version 9. I reviewed the amount of uses within the core. Result: Used in one place. See https://forge.typo3.org/issues/68748 for my full research and argumentation. I don't think that we should cling to a misleading and cluttered wording only because we are used to it. To improve TYPO3 we should aim to a clean API to keep TYPO3 attractive. -
Benni Mack commented on patch set 2 CR +1 08/12/15, 19:30
deprecate it in CMS9 is fine IMHO. We just need a deprecation RST file for it. -
Oliver Hader uploaded patch set 3 10/09/15, 06:31
-
Andreas Wolf uploaded patch set 4 03/04/16, 12:02
-
Benni Mack wrote 03/04/16, 12:08
Patch set 5: Published edit on patch set 4. -
Wouter Wolters voted on patch set 5 CR 0 03/05/16, 09:57
-
Elmar Hinz uploaded patch set 6 03/05/16, 16:56
-
Christian Kuhn commented on patch set 6 03/05/16, 17:37
the overall benefit of this rename is low to zero.10 ? -
Elmar Hinz commented on patch set 6 03/05/16, 17:38
Sorry, I hit the wrong button, when try to get a cherry pick. Patch set 6 is nonsense. Still don't know, how to undo. Please remove or ignore it. -
Andreas Wolf commented on patch set 6 03/05/16, 17:40
Reply
That’s what I thought would be the default deprecation policy. Seems to not be the case however ;-) Could be changed if we decide to keep this. -
Elmar Hinz abandoned the change 03/05/16, 17:55
Patch set6 is a gerrit usability mistake. -
Elmar Hinz restored the change 03/05/16, 17:58
Tried to abandon patch set6 not the whole process. Now try to restore. -
Elmar Hinz uploaded patch set 7 03/05/16, 18:28
-
Elmar Hinz uploaded patch set 8 03/05/16, 18:44
-
Elmar Hinz uploaded patch set 9 03/05/16, 19:11
-
Elmar Hinz commented on patch set 9 03/05/16, 19:13
Removing [!!!] from commit msg as a deprecation doesn't break anything. -
Benni Mack voted on patch set 9 CR +1 V +1 03/06/16, 00:03
-
Andreas Wolf wrote 03/06/16, 00:15
Patch set 10: Published edit on patch set 9. -
Andreas Wolf voted on patch set 10 CR +2 V +2 03/06/16, 00:15
-
Andreas Wolf wrote 03/06/16, 00:15
Patch set 11: Published edit on patch set 10. -
Andreas Wolf voted on patch set 11 CR +2 V +2 03/06/16, 00:16
-
Benni Mack voted on patch set 11 CR +1 V +1 03/06/16, 00:16
-
Gerrit merged patch set 11 03/06/16, 00:16
AbstractContentObject.php:56