Review main Merged

42272[CLEANUP] Rename AbstractContentObject::getContentObject()

Elmar Hinz CR +2 V +2 Easy +30 −3 updated 03/06/16, 00:16

Commit message

The method is renamed to getContentObjectRenderer(), as this better
reflects what it actually does. The old method is marked as deprecated
and scheduled for removal in v9.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Benni Mack +1
  • Verified V +2
    • Andreas Wolf +2
    • Benni Mack +1

Issues 1

Files 3

Review log 30

Show 5 earlier messages
  1. Elmar Hinz uploaded patch set 1 08/05/15, 11:39

  2. Mathias Brodala uploaded patch set 2 08/05/15, 11:59

  3. Mathias Brodala commented on patch set 2 08/05/15, 12:00

    AbstractContentObject.php:56

    I'd assume 8 here.
  4. Wouter Wolters commented on patch set 2 CR -1 08/05/15, 12:05

    1. I don't see any benefit in changing the name. 2. What is exactly breaking? Marking the commit with [!!!] means there breaks something but a deprecation doesn't break anything. 3. If this is accepted there needs to be an RST file that explains the deprecation. typo3/sysext/core/Documentation/ contains alot of examples. 4. The core should not use any deprecated methods. All core calls need to be adapted too.
  5. Elmar Hinz commented on patch set 2 08/05/15, 13:21

    1. The benefit is clearness of the wording. No, less, no more. You call getMilk and a cow is delivered? I gonna update 2. 3. 4.
  1. Christian Kuhn voted on patch set 2 CR -1 08/05/15, 13:55

  2. Wouter Wolters commented on patch set 2 CR -2 08/05/15, 14:55

    I discussed this with some people and the conclusion is that we don't gain anything here, only work for extension developers that use this method. Only a name change is not worth the hassle without having a tool that can do automatic migration of deprecated methods in your extension code. See also https://forge.typo3.org/issues/68175 for the story behind this.
  3. Elmar Hinz commented on patch set 2 08/05/15, 15:09

    @wouter: The extensions is the reason why I set the deprecation range to version 9. I reviewed the amount of uses within the core. Result: Used in one place. See https://forge.typo3.org/issues/68748 for my full research and argumentation. I don't think that we should cling to a misleading and cluttered wording only because we are used to it. To improve TYPO3 we should aim to a clean API to keep TYPO3 attractive.
  4. Benni Mack commented on patch set 2 CR +1 08/12/15, 19:30

    deprecate it in CMS9 is fine IMHO. We just need a deprecation RST file for it.
  5. Oliver Hader uploaded patch set 3 10/09/15, 06:31

  6. Andreas Wolf uploaded patch set 4 03/04/16, 12:02

  7. Benni Mack wrote 03/04/16, 12:08

    Patch set 5: Published edit on patch set 4.
  8. Wouter Wolters voted on patch set 5 CR 0 03/05/16, 09:57

  9. Elmar Hinz uploaded patch set 6 03/05/16, 16:56

  10. Christian Kuhn commented on patch set 6 03/05/16, 17:37

    the overall benefit of this rename is low to zero.
    10 ?
  11. Elmar Hinz commented on patch set 6 03/05/16, 17:38

    Sorry, I hit the wrong button, when try to get a cherry pick. Patch set 6 is nonsense. Still don't know, how to undo. Please remove or ignore it.
  12. Andreas Wolf commented on patch set 6 03/05/16, 17:40

    Reply

    That’s what I thought would be the default deprecation policy. Seems to not be the case however ;-) Could be changed if we decide to keep this.
  13. Elmar Hinz abandoned the change 03/05/16, 17:55

    Patch set6 is a gerrit usability mistake.
  14. Elmar Hinz restored the change 03/05/16, 17:58

    Tried to abandon patch set6 not the whole process. Now try to restore.
  15. Elmar Hinz uploaded patch set 7 03/05/16, 18:28

  16. Elmar Hinz uploaded patch set 8 03/05/16, 18:44

  17. Elmar Hinz uploaded patch set 9 03/05/16, 19:11

  18. Elmar Hinz commented on patch set 9 03/05/16, 19:13

    Removing [!!!] from commit msg as a deprecation doesn't break anything.
  19. Benni Mack voted on patch set 9 CR +1 V +1 03/06/16, 00:03

  20. Andreas Wolf wrote 03/06/16, 00:15

    Patch set 10: Published edit on patch set 9.
  21. Andreas Wolf voted on patch set 10 CR +2 V +2 03/06/16, 00:15

  22. Andreas Wolf wrote 03/06/16, 00:15

    Patch set 11: Published edit on patch set 10.
  23. Andreas Wolf voted on patch set 11 CR +2 V +2 03/06/16, 00:16

  24. Benni Mack voted on patch set 11 CR +1 V +1 03/06/16, 00:16

  25. Gerrit merged patch set 11 03/06/16, 00:16