Review main Merged

42274[FEATURE] Make "base" of stdWrap_bytes configurable

Manuel Selbach CR +2 V +2 Easy +31 −1 updated 08/05/15, 20:06

Commit message

It is possible now to set the base parameter via TypoScript to define
a base (1000 or 1024) to calculate with if you add custom labels for file
sizes. This allows proper handling of KB/KiB etc.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Wolf +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Wolf +1

Issues 1

Files 2

Review log 12

  1. Manuel Selbach uploaded patch set 1 08/05/15, 13:13

  2. Manuel Selbach uploaded patch set 2 08/05/15, 13:36

  3. Manuel Selbach uploaded patch set 3 08/05/15, 13:37

  4. Benni Mack voted on patch set 3 CR +1 08/05/15, 13:43

  5. Susi Moog commented on patch set 3 08/05/15, 14:54

    interesting base ;)

    Feature-68756-AddConfigBaseToStdWrap.rst:16

    not? Or was this meant as description of the behavior before the patch?
  6. Manuel Selbach commented on patch set 3 08/05/15, 15:41

    Feature-68756-AddConfigBaseToStdWrap.rst:16 Reply

    It´s the description before the path, yes
  7. Christian Kuhn updated the commit message in patch set 4 08/05/15, 19:26

  8. Christian Kuhn voted on patch set 4 CR +1 V +1 08/05/15, 19:28

  9. Andreas Wolf updated the commit message in patch set 5 08/05/15, 20:05

  10. Andreas Wolf voted on patch set 5 CR +1 V +1 08/05/15, 20:06

  11. Christian Kuhn voted on patch set 5 CR +2 V +2 08/05/15, 20:06

  12. Christian Kuhn merged patch set 5 08/05/15, 20:06