Review main Merged

42275[TASK] Allow command controller classes to reside in subfolders

Thorsten Boock CR +2 V +2 Easy +12 −5 updated 08/06/15, 11:11

Commit message

CommandController classes were required to reside in the main
folder inside Classes and have to be named like <name>CommandController.
With this change, the usage of subfolders is permitted, the namespace
needs to reflect the position under the Classes folder.
The CommandController Suffix is kept.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Felix Oertel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Felix Oertel +1

Issues 1

Files 2

Review log 17

  1. Thorsten Boock uploaded patch set 1 08/05/15, 13:58

  2. Mathias Brodala commented on patch set 1 CR -1 08/05/15, 14:13

    I agree that it should be possible to put command controllers in subdirectories the "CommandController" suffix should be kept as a good convention.
  3. Thorsten Boock commented on patch set 1 08/05/15, 14:21

    > the "CommandController" suffix should be kept as a > good convention. That check has not been removed and is still intact.
  4. Susi Moog voted on patch set 1 CR +1 08/05/15, 14:23

  5. Anja Leichsenring uploaded patch set 2 08/06/15, 07:46

  6. Sascha Wilking voted on patch set 2 V +1 08/06/15, 07:52

  7. Anja Leichsenring commented on patch set 2 CR -1 08/06/15, 07:54

    reworking unit tests
  8. Anja Leichsenring uploaded patch set 3 08/06/15, 07:56

  9. Anja Leichsenring voted on patch set 3 CR +1 V +1 08/06/15, 07:56

  10. Felix Oertel commented on patch set 3 CR +1 V +1 08/06/15, 08:02

    works on my machine ;-)
  11. Anja Leichsenring voted on patch set 3 CR +2 V +2 08/06/15, 08:19

  12. Anja Leichsenring merged patch set 3 08/06/15, 08:19

  13. Mathias Schreiber commented on patch set 4 08/06/15, 08:27

    Mathias Brodala will add an important rst file for this.
  14. Helmut Hummel commented on patch set 4 08/06/15, 08:32

    Tend to -1 post merge We loose the easy overview over all command controllers in an extensions (which might be debatable) and introduce a possibility for naming conflicts, which are not yet handled. Besides that, I'd say, this deserves a rst file and should be a feature, not a Task. It is a conceptual change how command controllers are resolved

    CommandTest.php:62

    This now has the possibility to conflict Tx_OtherExtensionKey_Foo_Faa_Fuuum_Command_CoffeeCommandController and Tx_OtherExtensionKey_Buzz_Command_CoffeeCommandController Will have the same command identifier. What is the expectations what happens in such a case?
  15. Benni Mack commented on patch set 4 08/06/15, 10:45

    I think we should make the registration more explicit $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['extbase']['commandControllers']['extensionmanager::extension'] = \TYPO3\CMS\Extensionmanager\Command\ExtensionCommandController::class; And solve it with the keys. So naming conflicts still exist, but we also don't have to worry about the whole "fetch the extension key" thing anymore.
  16. Thorsten Boock commented on patch set 4 08/06/15, 10:50

    I'm currently working on a solution for the naming conflicts. The basic idea is to add the sub-package to the command identifier, if the default namespace schema (Vendor\ExtensionName\Command) is not used.
  17. Mathias Brodala commented on patch set 4 08/06/15, 11:11

    I agree with Benny, especially in light of this issue: https://forge.typo3.org/issues/60381