42275[TASK] Allow command controller classes to reside in subfolders
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Felix Oertel +1
-
Verified V +2
- Anja Leichsenring +2
- Felix Oertel +1
Issues 1
Files 2
Review log 17
-
Thorsten Boock uploaded patch set 1 08/05/15, 13:58
-
Mathias Brodala commented on patch set 1 CR -1 08/05/15, 14:13
I agree that it should be possible to put command controllers in subdirectories the "CommandController" suffix should be kept as a good convention. -
Thorsten Boock commented on patch set 1 08/05/15, 14:21
> the "CommandController" suffix should be kept as a > good convention. That check has not been removed and is still intact. -
Susi Moog voted on patch set 1 CR +1 08/05/15, 14:23
-
Anja Leichsenring uploaded patch set 2 08/06/15, 07:46
-
Sascha Wilking voted on patch set 2 V +1 08/06/15, 07:52
-
Anja Leichsenring commented on patch set 2 CR -1 08/06/15, 07:54
reworking unit tests -
Anja Leichsenring uploaded patch set 3 08/06/15, 07:56
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 08/06/15, 07:56
-
Felix Oertel commented on patch set 3 CR +1 V +1 08/06/15, 08:02
works on my machine ;-) -
Anja Leichsenring voted on patch set 3 CR +2 V +2 08/06/15, 08:19
-
Anja Leichsenring merged patch set 3 08/06/15, 08:19
-
Mathias Schreiber commented on patch set 4 08/06/15, 08:27
Mathias Brodala will add an important rst file for this. -
Helmut Hummel commented on patch set 4 08/06/15, 08:32
Tend to -1 post merge We loose the easy overview over all command controllers in an extensions (which might be debatable) and introduce a possibility for naming conflicts, which are not yet handled. Besides that, I'd say, this deserves a rst file and should be a feature, not a Task. It is a conceptual change how command controllers are resolvedCommandTest.php:62This now has the possibility to conflict Tx_OtherExtensionKey_Foo_Faa_Fuuum_Command_CoffeeCommandController and Tx_OtherExtensionKey_Buzz_Command_CoffeeCommandController Will have the same command identifier. What is the expectations what happens in such a case? -
Benni Mack commented on patch set 4 08/06/15, 10:45
I think we should make the registration more explicit $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['extbase']['commandControllers']['extensionmanager::extension'] = \TYPO3\CMS\Extensionmanager\Command\ExtensionCommandController::class; And solve it with the keys. So naming conflicts still exist, but we also don't have to worry about the whole "fetch the extension key" thing anymore. -
Thorsten Boock commented on patch set 4 08/06/15, 10:50
I'm currently working on a solution for the naming conflicts. The basic idea is to add the sub-package to the command identifier, if the default namespace schema (Vendor\ExtensionName\Command) is not used. -
Mathias Brodala commented on patch set 4 08/06/15, 11:11
I agree with Benny, especially in light of this issue: https://forge.typo3.org/issues/60381