Review main Merged

42297[BUGFIX] DocumentEditController save broken

Christian Kuhn CR +2 V +2 Easy +10 −6 updated 08/05/15, 21:34

Commit message

With changing the input type=image to input type=submit, the x/y
values are no longer transferred the EditDocumentController
checked for, and content is no longer saved.
Adapt the controller code for the new parameters.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 7

  1. Christian Kuhn uploaded patch set 1 08/05/15, 20:53

  2. Christian Kuhn commented on patch set 1 08/05/15, 20:56

    fun part: the buttons are 1k px left in page quick edit & rte fullscreen.
  3. Wouter Wolters commented on patch set 1 CR -1 08/05/15, 21:19

    Needs more love which I will take care off
  4. Wouter Wolters uploaded patch set 2 08/05/15, 21:29

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 08/05/15, 21:34

  6. Benni Mack voted on patch set 2 CR +2 V +2 08/05/15, 21:34

  7. Benni Mack merged patch set 2 08/05/15, 21:34