42298[BUGFIX] Submitted form data has precedence over value argument
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Sascha Wilking +1
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Sascha Wilking +1
Issues 2
Files 17
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-66588-POSTDataInSelectviewhelperShouldHaveHigherPriorityThanValueValue.rstnew+36 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+138 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php1+28 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+33 −25
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+13 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+19 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+3 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php+5 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php+3 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php+3 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php+248 −79
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/CheckboxViewHelperTest.php+10 −10
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php+4 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/RadioViewHelperTest.php+9 −7
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+4 −1
Review log 14
-
Markus Günther uploaded patch set 1 08/05/15, 21:05
-
Markus Günther commented on patch set 1 08/05/15, 21:05
I still need to fix the unit test. -
Mathias Brodala commented on patch set 1 CR -1 08/06/15, 07:11
Please add a Deprecation .rst for this.ButtonViewHelper.php:115Maybe put this into a Trait to avoid code duplication? -
Markus Günther uploaded patch set 2 08/06/15, 09:18
-
Markus Günther commented on patch set 2 08/06/15, 09:20
Still need to fix the unit tests, but find another way to prevent the code duplication. Discussed that with Frank and Anja! -
Markus Günther uploaded patch set 3 08/06/15, 12:29
-
Markus Günther commented on patch set 2 08/06/15, 12:30
Ok now ready for review and with working tests. -
Sascha Wilking voted on patch set 3 CR +1 V +1 08/06/15, 16:39
-
Anja Leichsenring uploaded patch set 4 08/06/15, 17:01
-
Sascha Wilking voted on patch set 4 CR +1 V +1 08/06/15, 17:01
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 08/06/15, 17:04
-
Susi Moog voted on patch set 4 CR +1 08/06/15, 17:10
-
Anja Leichsenring voted on patch set 4 CR +2 V +2 08/06/15, 17:10
-
Anja Leichsenring merged patch set 4 08/06/15, 17:10