Review main Merged

42312[TASK] BACK_PATH DocumentTemplate

Christian Kuhn CR +2 V +2 Easy +3 −45 updated 08/06/15, 12:53

Commit message

BACK_PATH in Backend context is always empty string. The patch
removes a couple of simple usages, mostly related to DocumentTemplate.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 1

Files 35

Show 15 more files

Review log 8

  1. Christian Kuhn uploaded patch set 1 08/06/15, 11:31

  2. Christian Kuhn commented on patch set 1 08/06/15, 11:34

    DatabaseIntegrityCheck.php:62

    only a property ... could be set by extensions even if not declared any longer ...
  3. Georg Ringer updated the commit message in patch set 2 08/06/15, 12:21

  4. Wouter Wolters voted on patch set 2 V +1 CR +1 08/06/15, 12:26

  5. Anja Leichsenring commented on patch set 2 V -1 08/06/15, 12:37

    sorry breaks functional tests
  6. Anja Leichsenring commented on patch set 2 CR +1 V +1 08/06/15, 12:47

    I apologize, the patch is fine, a formerly merged patched caused the test failure.
  7. Wouter Wolters voted on patch set 2 V +2 CR +2 08/06/15, 12:53

  8. Wouter Wolters merged patch set 2 08/06/15, 12:53