Review main Merged

42320[TASK] BACK_PATH RecordList and friends

Wouter Wolters CR +2 V +2 Normal +49 −155 updated 08/06/15, 18:20

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 1

Files 35

Show 15 more files

Review log 13

  1. Wouter Wolters uploaded patch set 1 08/06/15, 14:06

  2. Wouter Wolters uploaded patch set 2 08/06/15, 15:19

  3. Wouter Wolters uploaded patch set 3 08/06/15, 15:41

  4. Benni Mack commented on patch set 3 08/06/15, 15:58

    Clipboard.php:526

    should be done like above (giving the ID variable as second parameter as an array)

    DocumentTemplate.php:525

    can be marked for deprecation so the parameter is removed in v8

    DocumentTemplate.php:584

    can be completely removed

    DocumentTemplate.php:1139

    wtf? :) we can get rid of the if construct completely

    PageRenderer.php:1954

    double ((

    PageRenderer.php:1971

    doubled ((

    PageRenderer.php:2002

    same here

    PageRenderer.php:2084

    interesting to know if all this works in the Frontend still?

    AbstractDatabaseRecordList.php:613

    remove that one completely?
  5. Christian Kuhn commented on patch set 3 CR -1 08/06/15, 16:22

    working on it.
  6. Christian Kuhn commented on patch set 3 08/06/15, 16:47

    Clipboard.php:526 Reply

    Done

    AbstractWizardController.php:83

    this was added between somewhere in 7 ... imho ok to drop this without deprecation.

    DocumentTemplate.php:525 Reply

    Done

    DocumentTemplate.php:584 Reply

    Done

    DocumentTemplate.php:1139 Reply

    Done

    PageRenderer.php:1954 Reply

    Done

    PageRenderer.php:1971 Reply

    Done

    PageRenderer.php:2002 Reply

    Done

    AbstractDatabaseRecordList.php:613 Reply

    Done
  7. Christian Kuhn uploaded patch set 4 08/06/15, 16:49

  8. Christian Kuhn commented on patch set 3 08/06/15, 16:58

    we'll kick out the PageRenderer part, since this is used in the FE and eg. jquery inclusion fails ... the deal is: kick backPath for BE stuff for now ...
  9. Christian Kuhn uploaded patch set 5 08/06/15, 17:01

  10. Christian Kuhn uploaded patch set 6 08/06/15, 17:08

  11. Christian Kuhn voted on patch set 6 CR +1 V +1 08/06/15, 17:12

  12. Benni Mack voted on patch set 6 CR +2 V +2 08/06/15, 18:19

  13. Benni Mack merged patch set 6 08/06/15, 18:20