Review main Abandoned

42322[BUGFIX] Prevent command controller naming conflicts

Thorsten Boock CR 0 V 0 Hard +262 −109 updated 03/28/17, 15:01

Commit message

Equally named command controllers in different sub-packages
always caused naming conflicts.
This change aims to prevent these conflicts by including
the sub-package name in the short command identifier.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 16

  1. Thorsten Boock uploaded patch set 1 08/06/15, 14:51

  2. Thorsten Boock uploaded patch set 2 08/06/15, 14:55

  3. Oliver Hader uploaded patch set 3 10/09/15, 06:33

  4. Thomas Maroschik updated the commit message in patch set 4 10/26/15, 14:35

  5. Anja Leichsenring commented on patch set 4 V -1 03/06/16, 12:08

    Causes Unit tests to fail. Otherwise fine, looks good.
  6. Mathias Schreiber wrote 04/09/16, 20:31

    Topic changed from 68758 to UXW
  7. Anja Leichsenring uploaded patch set 5 06/02/16, 19:36

  8. Anja Leichsenring commented on patch set 4 06/02/16, 19:37

    this is only a cleanup of the involved test classes. Real changes follow.
  9. Anja Leichsenring uploaded patch set 6 06/02/16, 20:18

  10. Anja Leichsenring voted on patch set 6 CR +1 V +1 06/02/16, 20:18

  11. Frank Nägler commented on patch set 6 CR -1 06/06/16, 14:50

    temporary -1, Anja and I will check some things
  12. Helmut Hummel commented on patch set 6 06/06/16, 19:07

    CommandTest.php:85

    didn't we agree to keep the object call syntax?
  13. Wouter Wolters commented on patch set 6 06/06/16, 19:18

    CommandTest.php:85 Reply

    yes, this needs to be undone here.
  14. Wouter Wolters commented on patch set 6 06/06/16, 19:19

    CommandTest.php:85 Reply

    See also this ticket in the phpunit project https://github.com/sebastianbergmann/phpunit/issues/2185
  15. Anja Leichsenring commented on patch set 6 06/07/16, 14:06

    This patch needs an upgrade wizard to update existing scheduler tasks, and as it is breaking, a rst file, too.
  16. Benni Mack abandoned the change 03/28/17, 15:01

    No activity for almost a year, will abandon it for now. If you want to continue on that, you can restore the patch.