42323[BUGFIX] Fix http_request2 and add test to verify that.
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Mathias Brodala +1
-
Verified V +2
- Wouter Wolters +2
- Mathias Brodala +1
Issues 1
Files 3
Review log 13
-
Helmut Hummel uploaded patch set 1 08/06/15, 15:28
-
Mathias Brodala commented on patch set 1 08/06/15, 15:40
-
Helmut Hummel uploaded patch set 2 08/06/15, 16:30
-
Helmut Hummel commented on patch set 2 CR -2 08/06/15, 16:33
just to demonstrate what is possible -
Helmut Hummel uploaded patch set 3 10/08/15, 10:26
-
Helmut Hummel uploaded patch set 4 10/08/15, 10:44
-
Wouter Wolters voted on patch set 4 V +1 CR +1 10/08/15, 10:52
-
Mathias Brodala voted on patch set 4 CR +1 V +1 10/08/15, 10:54
-
Helmut Hummel voted on patch set 4 CR 0 10/08/15, 10:59
-
Wouter Wolters voted on patch set 4 V +2 CR +2 10/08/15, 10:59
-
Wouter Wolters merged patch set 4 10/08/15, 10:59
-
Claus Due commented on patch set 5 11/15/16, 13:26
This one has severely broken the composer class loading of these files if composer mode is enabled and attempting to upgrade the library. Short reason: the include paths resolve to ./typo3_src/vendor/pear/http_request2 - which of course does not exist. However, ./vendor/pear/http_request2 exists. Removing the two autoloading entries solves the problem (with PEAR/Http_Request2 2.3.0+). -
Claus Due commented on patch set 5 11/15/16, 13:52
Follow-up to fix: https://review.typo3.org/#/c/48692/
composer.json:22