Review main Merged

42324[BUGFIX] EM: Adjust import-handling for deactivated auto-install

Daniel Goerz CR +2 V +2 Normal +52 −28 updated 08/06/15, 17:48

Commit message

If automaticInstallation is turned off in extension manager settings,
dependency-checks are not done anymore (as no installation is done in
that case).

The tooltip in the "Get Extensions" list has also been adjusted:
- "Import" if automaticInstallation is turned off
- "Import and install" if automaticInstallation is turned on

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Sascha Wilking +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Sascha Wilking +1

Issues 1

Files 5

Review log 9

  1. Daniel Goerz uploaded patch set 1 08/06/15, 15:42

  2. Daniel Goerz commented on patch set 1 08/06/15, 15:43

    This patch only changes the label of the submit button. To disable dependency checks upon extension donwload as stated in the forge ticket some more work has to be done.
  3. Daniel Maier commented on patch set 1 V -1 08/06/15, 15:55

    On it... Will provide the missing part for disabling the dependency checks here
  4. Daniel Maier commented on patch set 1 08/06/15, 16:02

    locallang.xlf:329

    Would prefer to append .downloadOnly here as it is already done for related extensionList.dependenciesResolveDownloadSuccess.message.downloadOnly

    locallang.xlf:332

    Better to leave the existing key unchanged and introduce a new key for the new label.
  5. Daniel Maier uploaded patch set 2 08/06/15, 16:57

  6. Sascha Wilking voted on patch set 2 CR +1 V +1 08/06/15, 17:11

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 08/06/15, 17:24

  8. Andreas Kienast voted on patch set 2 CR +2 V +2 08/06/15, 17:48

  9. Andreas Kienast merged patch set 2 08/06/15, 17:48