42324[BUGFIX] EM: Adjust import-handling for deactivated auto-install
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Anja Leichsenring +1
- Sascha Wilking +1
-
Verified V +2
- Andreas Kienast +2
- Anja Leichsenring +1
- Sascha Wilking +1
Issues 1
Files 5
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+31 −24
- typo3/sysext/extensionmanager/Classes/Utility/DownloadUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+16 −2
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf2+3 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/Download/CheckDependencies.json+1 −1
Review log 9
-
Daniel Goerz uploaded patch set 1 08/06/15, 15:42
-
Daniel Goerz commented on patch set 1 08/06/15, 15:43
This patch only changes the label of the submit button. To disable dependency checks upon extension donwload as stated in the forge ticket some more work has to be done. -
Daniel Maier commented on patch set 1 V -1 08/06/15, 15:55
On it... Will provide the missing part for disabling the dependency checks here -
Daniel Maier commented on patch set 1 08/06/15, 16:02
locallang.xlf:329Would prefer to append .downloadOnly here as it is already done for related extensionList.dependenciesResolveDownloadSuccess.message.downloadOnlylocallang.xlf:332Better to leave the existing key unchanged and introduce a new key for the new label. -
Daniel Maier uploaded patch set 2 08/06/15, 16:57
-
Sascha Wilking voted on patch set 2 CR +1 V +1 08/06/15, 17:11
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 08/06/15, 17:24
-
Andreas Kienast voted on patch set 2 CR +2 V +2 08/06/15, 17:48
-
Andreas Kienast merged patch set 2 08/06/15, 17:48