Review main Merged

42336[TASK] Update to class-alias-loader 2.x

Helmut Hummel CR +2 V +2 Normal +32 −25 updated 08/07/15, 09:35

Commit message

Update to latest refactored version of the class-alias-loader.
This might be the last iteration before this package is moved
to TYPO3 namespace.

The alias loader has been refactored, cleaned up, moved to PSR-2.
Documentation and tests have been added.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Helmut Hummel +1

Issues 1

Files 10

Review log 9

  1. Helmut Hummel uploaded patch set 1 08/06/15, 22:24

  2. Benni Mack updated the commit message in patch set 2 08/06/15, 22:36

  3. Christian Kuhn commented on patch set 2 V -1 08/07/15, 08:30

    Fatal error: Class 'Helhum\ClassAliasLoader\Composer\ClassAliasLoader' not found in /var/www/t3master/cms/typo3/sysext/core/Classes/Core/ClassLoadingInformation.php on line 198
  4. Christian Kuhn uploaded patch set 3 08/07/15, 08:37

  5. Christian Kuhn commented on patch set 3 08/07/15, 08:37

    Wrong class name was referenced ... Helmut, could you have another look, please?
  6. Helmut Hummel commented on patch set 3 CR +1 V +1 08/07/15, 09:13

    doh, thanks!
  7. Wouter Wolters voted on patch set 3 V +1 CR +1 08/07/15, 09:25

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 08/07/15, 09:35

  9. Christian Kuhn merged patch set 3 08/07/15, 09:35