Review main Merged

42343[BUGFIX] Use FAL object name directly in Filelist clipboard message

Andreas Kienast CR +2 V +2 Easy +4 −8 updated 08/10/15, 07:26

Commit message

There is no need to obtain file informations if only the name is
required, which is already available, so access it directly. This also
fixes the uncaught exception when copying a folder.

Review

  • Code review CR +2
    • Benni Mack +2
    • Frans Saris +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Frans Saris +1
    • Andreas Kienast +1

Issues 1

Files 2

Review log 17

  1. Andreas Kienast uploaded patch set 1 08/07/15, 07:50

  2. Andreas Kienast commented on patch set 1 V -1 CR -1 08/07/15, 08:03

    Will be changed later, Steffen pointed some things out
  3. Frans Saris commented on patch set 1 08/07/15, 12:40

    FileList.php:269

    the whole $fileInfo isn't needed. just use $clipBoardItem->getName()
  4. Andreas Kienast uploaded patch set 2 08/08/15, 15:26

  5. Andreas Kienast updated the commit message in patch set 3 08/08/15, 15:28

  6. Philipp Gampe voted on patch set 3 CR +1 V +1 08/08/15, 15:45

  7. Frans Saris commented on patch set 3 08/08/15, 16:23

    Why identifier and not name? If I read the code correct it is to display some message and then name is more appropriate then identifier especially in file systems where the identifier isn't the file path.
  8. Andreas Kienast uploaded patch set 4 08/08/15, 17:13

  9. Frans Saris updated the commit message in patch set 5 08/08/15, 17:17

  10. Frans Saris voted on patch set 5 CR +1 08/08/15, 17:17

  11. Frans Saris commented on patch set 5 CR -1 V -1 08/09/15, 08:10

    Click menu still fails. working on it
  12. Frans Saris uploaded patch set 6 08/09/15, 08:18

  13. Frans Saris voted on patch set 6 CR +1 V +1 08/09/15, 08:19

  14. Andreas Kienast voted on patch set 6 CR +1 V +1 08/10/15, 07:18

  15. Benni Mack voted on patch set 6 CR +2 08/10/15, 07:22

  16. Benni Mack voted on patch set 6 V +2 08/10/15, 07:26

  17. Benni Mack merged patch set 6 08/10/15, 07:26