Review main Merged

42349[BUGFIX] Async broken dialog message for adding new shortcut entry

Sascha Wilking CR +2 V +2 Easy +17 −21 updated 08/07/15, 09:58

Commit message

With adding a new entry to the shortcut list the new fancy dialog
window stuff will open. but your choice cannot be "respected"
because the adding action was already done before the dialog
window is open.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Sascha Wilking uploaded patch set 1 08/07/15, 09:13

  2. Wouter Wolters commented on patch set 1 V +1 CR +1 08/07/15, 09:20

    Good catch
  3. Anja Leichsenring voted on patch set 1 CR +2 V +2 08/07/15, 09:55

  4. Anja Leichsenring merged patch set 1 08/07/15, 09:55

  5. Frank Nägler commented on patch set 1 08/07/15, 09:58

    post +1/+1 thx for the patch, could catch.