Review main Merged

42377[BUGFIX] Missing active state for shortcut button

Sascha Wilking CR +2 V +2 Normal +79 −17 updated 08/07/15, 13:02

Commit message

After adding a page to bookmark list, the shortcut button gets an
active state now. The shortcut button is disabled then and can not
be clicked for a second time.

Review

  • Code review CR +2
    • Susi Moog +2
    • Jan Runte +1
    • Anja Leichsenring +1
  • Verified V +2
    • Susi Moog +2
    • Jan Runte +1
    • Anja Leichsenring +1

Issues 1

Files 6

Review log 14

  1. Sascha Wilking uploaded patch set 1 08/07/15, 12:34

  2. Anja Leichsenring updated the commit message in patch set 2 08/07/15, 12:38

  3. Anja Leichsenring updated the commit message in patch set 3 08/07/15, 12:39

  4. Sascha Wilking uploaded patch set 4 08/07/15, 12:54

  5. Jan Runte commented on patch set 4 CR -1 V -1 08/07/15, 12:57

    Looking through eyes... on scren
  6. Jan Runte voted on patch set 4 V +1 CR +1 08/07/15, 12:57

  7. Jan Runte commented on patch set 4 08/07/15, 12:58

    Looking through eyes... on scren all fine. all done.
  8. Susi Moog commented on patch set 4 CR -1 08/07/15, 12:59

    Anja will push an update.
  9. Anja Leichsenring uploaded patch set 5 08/07/15, 13:00

  10. Anja Leichsenring voted on patch set 5 CR +1 V +1 08/07/15, 13:01

  11. Jan Runte voted on patch set 5 CR +1 08/07/15, 13:01

  12. Jan Runte voted on patch set 5 V +1 08/07/15, 13:01

  13. Susi Moog voted on patch set 5 CR +2 V +2 08/07/15, 13:02

  14. Susi Moog merged patch set 5 08/07/15, 13:02